-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default_value to the cost category data source. #29291
Add default_value to the cost category data source. #29291
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCECostCategoryDataSource_' PKG=ce ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 3 -run=TestAccCECostCategoryDataSource_ -timeout 180m
=== RUN TestAccCECostCategoryDataSource_basic
=== PAUSE TestAccCECostCategoryDataSource_basic
=== CONT TestAccCECostCategoryDataSource_basic
--- PASS: TestAccCECostCategoryDataSource_basic (17.66s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 25.762s
@jimrazmus Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds 'default_value' to the cost category data source.
This is an important addition given that a default_value may be an instrumental part of a rule set. The 'default value' may be capturing material costs not explicitly categorized by other rules.
Relations
NA
References
NA
Output from Acceptance Testing
I didn't run acceptance tests as I don't have an AWS management account suitable for testing.