Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: aws_auditmanager_framework #28989

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jan 19, 2023

Description

aws_auditmanager_framework will allow practitioners to utilize Standard (AWS-managed) assessment frameworks as inputs to other resources, such as Assessments.

Relations

Relates #17981

Output from Acceptance Testing

$ make testacc PKG=auditmanager TESTS=TestAccAuditManagerFrameworkDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/auditmanager/... -v -count 1 -parallel 20 -run='TestAccAuditManagerFrameworkDataSource_'  -timeout 180m
=== RUN   TestAccAuditManagerFrameworkDataSource_standard
=== PAUSE TestAccAuditManagerFrameworkDataSource_standard
=== RUN   TestAccAuditManagerFrameworkDataSource_custom
=== PAUSE TestAccAuditManagerFrameworkDataSource_custom
=== CONT  TestAccAuditManagerFrameworkDataSource_standard
=== CONT  TestAccAuditManagerFrameworkDataSource_custom
--- PASS: TestAccAuditManagerFrameworkDataSource_standard (12.19s)
--- PASS: TestAccAuditManagerFrameworkDataSource_custom (14.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/auditmanager       17.392s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/auditmanager Issues and PRs that pertain to the auditmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 19, 2023
@jar-b jar-b mentioned this pull request Jan 19, 2023
13 tasks
@jar-b jar-b marked this pull request as ready for review January 19, 2023 21:49
@jar-b jar-b merged commit a97f654 into main Jan 20, 2023
@jar-b jar-b deleted the f-aws_auditmanager_framework_data_source branch January 20, 2023 14:00
@github-actions github-actions bot added this to the v4.52.0 milestone Jan 20, 2023
jar-b added a commit that referenced this pull request Jan 20, 2023
@jar-b jar-b mentioned this pull request Jan 20, 2023
@github-actions
Copy link

This functionality has been released in v4.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/auditmanager Issues and PRs that pertain to the auditmanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant