-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_opensearchserverless_access_policy resource #28518
Add aws_opensearchserverless_access_policy resource #28518
Conversation
Community NoteVoting for Prioritization
For Submitters
|
1cba473
to
1377c1b
Compare
Is there anything stopping this PR from being merged so that the work on #28462 can be completed? This serverless went to GA over a month ago and this code appears to have been done a few months ago. |
@jtbrush56 this, and #28470 are just waiting on the fine folks at Hashicorp to find time to review them. With over ~3,700 open issues and ~400 open PRs they have to employ a strict prioritisation to their work. I have enquired with them about the OpenSearch Serverless PRs and they're fully aware of the high level of user interest in them so are doing what they can to get them toward the top of the prioritisation backlog. |
1377c1b
to
0f69d9c
Compare
Thanks for all you've done on this and for getting the code complete on it. Have you heard any update from Hashicorp about the status of these PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc TESTS=TestAccOpenSearchServerlessAccessPolicy_ PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessAccessPolicy_' -timeout 180m
--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (86.57s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (116.09s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_update (174.07s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless 177.458s
@mattburgess thanks for the contribution! 🎉 |
This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for OpenSearch Serverless Access Policy resources.
Relations
Closes #28459
References
Output from Acceptance Testing