Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_opensearchserverless_access_policy resource #28518

Merged

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Dec 21, 2022

Description

Adds support for OpenSearch Serverless Access Policy resources.

Relations

Closes #28459

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccOpenSearchServerlessAccessPolicy_ PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessAccessPolicy_'  -timeout 180m
=== RUN   TestAccOpenSearchServerlessAccessPolicy_basic
=== PAUSE TestAccOpenSearchServerlessAccessPolicy_basic
=== RUN   TestAccOpenSearchServerlessAccessPolicy_disappears
=== PAUSE TestAccOpenSearchServerlessAccessPolicy_disappears
=== CONT  TestAccOpenSearchServerlessAccessPolicy_basic
=== CONT  TestAccOpenSearchServerlessAccessPolicy_disappears
--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (15.14s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (18.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	18.759s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Dec 21, 2022
@mattburgess mattburgess force-pushed the opensearchserverless-access-policy-resource branch 3 times, most recently from 1cba473 to 1377c1b Compare December 22, 2022 11:22
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2023
@jtbrush56
Copy link

Is there anything stopping this PR from being merged so that the work on #28462 can be completed? This serverless went to GA over a month ago and this code appears to have been done a few months ago.

@mattburgess
Copy link
Collaborator Author

Is there anything stopping this PR from being merged so that the work on #28462 can be completed? This serverless went to GA over a month ago and this code appears to have been done a few months ago.

@jtbrush56 this, and #28470 are just waiting on the fine folks at Hashicorp to find time to review them. With over ~3,700 open issues and ~400 open PRs they have to employ a strict prioritisation to their work. I have enquired with them about the OpenSearch Serverless PRs and they're fully aware of the high level of user interest in them so are doing what they can to get them toward the top of the prioritisation backlog.

@mattburgess mattburgess force-pushed the opensearchserverless-access-policy-resource branch from 1377c1b to 0f69d9c Compare March 22, 2023 19:59
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 22, 2023
@AdamTylerLynch AdamTylerLynch self-requested a review April 4, 2023 20:06
@jtbrush56
Copy link

Is there anything stopping this PR from being merged so that the work on #28462 can be completed? This serverless went to GA over a month ago and this code appears to have been done a few months ago.

@jtbrush56 this, and #28470 are just waiting on the fine folks at Hashicorp to find time to review them. With over ~3,700 open issues and ~400 open PRs they have to employ a strict prioritisation to their work. I have enquired with them about the OpenSearch Serverless PRs and they're fully aware of the high level of user interest in them so are doing what they can to get them toward the top of the prioritisation backlog.

Thanks for all you've done on this and for getting the code complete on it. Have you heard any update from Hashicorp about the status of these PRs?

@johnsonaj johnsonaj self-assigned this Jun 7, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTS=TestAccOpenSearchServerlessAccessPolicy_ PKG=opensearchserverless

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessAccessPolicy_'  -timeout 180m
--- PASS: TestAccOpenSearchServerlessAccessPolicy_disappears (86.57s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_basic (116.09s)
--- PASS: TestAccOpenSearchServerlessAccessPolicy_update (174.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	177.458s

@johnsonaj
Copy link
Contributor

@mattburgess thanks for the contribution! 🎉

@johnsonaj johnsonaj merged commit b5d1282 into hashicorp:main Jun 12, 2023
@github-actions github-actions bot added this to the v5.3.0 milestone Jun 12, 2023
@github-actions
Copy link

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: OpenSearch Serverless Access Policy
5 participants