Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force recreation of aws_lb_target_groups on health check modifications #28018

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Don't force recreation of aws_lb_target_groups on health check modifications #28018

merged 6 commits into from
Dec 8, 2022

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Nov 25, 2022 •
edited
Loading

Description

The elbv2 API permits health checks to be modified in place, so this removes the diff customisation pieces that were forcing recreation. It also removes some additional constraints that the API has removed.

Relations

Closes #25338

References

https://docs.aws.amazon.com/sdk-for-go/api/service/elbv2/#CreateTargetGroupInput

Output from Acceptance Testing

$ make testacc TESTS=TestAccELBV2TargetGroup_ PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3 -run='TestAccELBV2TargetGroup_'  -timeout 180m
=== RUN   TestAccELBV2TargetGroup_backwardsCompatibility
=== PAUSE TestAccELBV2TargetGroup_backwardsCompatibility
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== RUN   TestAccELBV2TargetGroup_ipAddressType
=== PAUSE TestAccELBV2TargetGroup_ipAddressType
=== RUN   TestAccELBV2TargetGroup_tls
=== PAUSE TestAccELBV2TargetGroup_tls
=== RUN   TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== RUN   TestAccELBV2TargetGroup_attrsOnCreate
=== PAUSE TestAccELBV2TargetGroup_attrsOnCreate
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== RUN   TestAccELBV2TargetGroup_udp
=== PAUSE TestAccELBV2TargetGroup_udp
=== RUN   TestAccELBV2TargetGroup_ForceNew_name
=== PAUSE TestAccELBV2TargetGroup_ForceNew_name
=== RUN   TestAccELBV2TargetGroup_ForceNew_port
=== PAUSE TestAccELBV2TargetGroup_ForceNew_port
=== RUN   TestAccELBV2TargetGroup_ForceNew_protocol
=== PAUSE TestAccELBV2TargetGroup_ForceNew_protocol
=== RUN   TestAccELBV2TargetGroup_ForceNew_vpc
=== PAUSE TestAccELBV2TargetGroup_ForceNew_vpc
=== RUN   TestAccELBV2TargetGroup_Defaults_application
=== PAUSE TestAccELBV2TargetGroup_Defaults_application
=== RUN   TestAccELBV2TargetGroup_Defaults_network
=== PAUSE TestAccELBV2TargetGroup_Defaults_network
=== RUN   TestAccELBV2TargetGroup_HealthCheck_enable
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_enable
=== RUN   TestAccELBV2TargetGroup_Name_generated
=== PAUSE TestAccELBV2TargetGroup_Name_generated
=== RUN   TestAccELBV2TargetGroup_Name_prefix
=== PAUSE TestAccELBV2TargetGroup_Name_prefix
=== RUN   TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
=== RUN   TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== PAUSE TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== RUN   TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== RUN   TestAccELBV2TargetGroup_preserveClientIPValid
=== PAUSE TestAccELBV2TargetGroup_preserveClientIPValid
=== RUN   TestAccELBV2TargetGroup_Geneve_basic
=== PAUSE TestAccELBV2TargetGroup_Geneve_basic
=== RUN   TestAccELBV2TargetGroup_Geneve_notSticky
=== PAUSE TestAccELBV2TargetGroup_Geneve_notSticky
=== RUN   TestAccELBV2TargetGroup_Geneve_Sticky
=== PAUSE TestAccELBV2TargetGroup_Geneve_Sticky
=== RUN   TestAccELBV2TargetGroup_Geneve_targetFailover
=== PAUSE TestAccELBV2TargetGroup_Geneve_targetFailover
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validNLB
=== RUN   TestAccELBV2TargetGroup_tags
=== PAUSE TestAccELBV2TargetGroup_tags
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_update
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_update
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_without
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_without
=== RUN   TestAccELBV2TargetGroup_ALBAlias_basic
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_basic
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_generatedName
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_generatedName
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambda
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambda
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== RUN   TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== RUN   TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== RUN   TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== RUN   TestAccELBV2TargetGroup_ALBAlias_tags
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_tags
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== CONT  TestAccELBV2TargetGroup_backwardsCompatibility
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidALB
=== CONT  TestAccELBV2TargetGroup_Defaults_network
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (15.68s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
--- PASS: TestAccELBV2TargetGroup_Defaults_network (17.85s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (30.93s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (31.46s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (43.44s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_tags
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (43.05s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (30.14s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_namePrefix
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (31.00s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (16.60s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (31.06s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambda
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC (19.31s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_generatedName
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (18.38s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (18.14s)
=== CONT  TestAccELBV2TargetGroup_preserveClientIPValid
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (41.91s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultNLB
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (30.30s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultALB
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (30.50s)
=== CONT  TestAccELBV2TargetGroup_Geneve_targetFailover
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (16.71s)
=== CONT  TestAccELBV2TargetGroup_Geneve_Sticky
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (45.47s)
=== CONT  TestAccELBV2TargetGroup_Geneve_notSticky
--- PASS: TestAccELBV2TargetGroup_Geneve_targetFailover (36.72s)
=== CONT  TestAccELBV2TargetGroup_Geneve_basic
--- PASS: TestAccELBV2TargetGroup_Geneve_Sticky (31.48s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (31.84s)
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (20.65s)
=== CONT  TestAccELBV2TargetGroup_Defaults_application
--- PASS: TestAccELBV2TargetGroup_basic (17.16s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_vpc
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (30.46s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_protocol
--- PASS: TestAccELBV2TargetGroup_Defaults_application (16.80s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_port
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (29.91s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_name
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (31.40s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (31.86s)
=== CONT  TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (33.11s)
=== CONT  TestAccELBV2TargetGroup_ipAddressType
--- PASS: TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated (30.64s)
=== CONT  TestAccELBV2TargetGroup_udp
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (31.25s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
--- PASS: TestAccELBV2TargetGroup_udp (17.57s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_update
--- PASS: TestAccELBV2TargetGroup_ipAddressType (20.46s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (31.20s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (30.98s)
=== CONT  TestAccELBV2TargetGroup_attrsOnCreate
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (30.94s)
=== CONT  TestAccELBV2TargetGroup_tls
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (32.20s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
--- PASS: TestAccELBV2TargetGroup_tls (17.13s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (31.77s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_basic
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (17.96s)
=== CONT  TestAccELBV2TargetGroup_Name_generated
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (17.38s)
=== CONT  TestAccELBV2TargetGroup_Name_prefix
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (33.83s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validNLB
--- PASS: TestAccELBV2TargetGroup_Name_generated (17.82s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
--- PASS: TestAccELBV2TargetGroup_Name_prefix (18.76s)
=== CONT  TestAccELBV2TargetGroup_tags
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (46.26s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_without
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (60.64s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateEnabled
--- PASS: TestAccELBV2TargetGroup_tags (46.93s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (15.59s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_enable
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (17.69s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validALB
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (27.58s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidNLB
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (46.69s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (33.15s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (27.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	514.016s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 25, 2022
@mattburgess
Copy link
Collaborator Author

One test failure to investigate:

=== CONT  TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
    target_group_test.go:748: Step 2/2 error: Error running apply: exit status 1
        
        Error: modifying Target Group: ValidationError: Health check interval must be greater than the timeout.
        	status code: 400, request id: 0a6f31a3-22ad-43fc-bbc3-77b829af489a
        
          with aws_lb_target_group.test,
          on terraform_plugin_test.tf line 2, in resource "aws_lb_target_group" "test":
           2: resource "aws_lb_target_group" "test" {
        
--- FAIL: TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated (22.86s)

func testAccTargetGroupConfig_typeTCPHealthCheckUpdated(rName string) string {
	return fmt.Sprintf(`
resource "aws_lb_target_group" "test" {
  name     = %[1]q
  port     = 8082
  protocol = "TCP"
  vpc_id   = aws_vpc.test.id

  deregistration_delay = 200

  health_check {
    interval            = 20
    port                = "8081"
    protocol            = "TCP"
    timeout             = 15
    healthy_threshold   = 4
    unhealthy_threshold = 5
  }

  tags = {
    Name = %[1]q
  }
}

I think, despite my earlier testing, that the timeout might not be able to be set on initial creation/modification. Will take a look soonish.

@ewbankkit ewbankkit changed the title Don't force recreation of aws_lb_target_groups on health check modifi… Don't force recreation of aws_lb_target_groups on health check modifications Nov 28, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 28, 2022
@mattburgess
Copy link
Collaborator Author

All tests are passing now.

ewbankkit
ewbankkit approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2TargetGroup_' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2TargetGroup_ -timeout 180m
=== RUN   TestAccELBV2TargetGroup_backwardsCompatibility
=== PAUSE TestAccELBV2TargetGroup_backwardsCompatibility
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_basic
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_basic
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
=== RUN   TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== PAUSE TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
=== RUN   TestAccELBV2TargetGroup_ipAddressType
=== PAUSE TestAccELBV2TargetGroup_ipAddressType
=== RUN   TestAccELBV2TargetGroup_tls
=== PAUSE TestAccELBV2TargetGroup_tls
=== RUN   TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
=== RUN   TestAccELBV2TargetGroup_attrsOnCreate
=== PAUSE TestAccELBV2TargetGroup_attrsOnCreate
=== RUN   TestAccELBV2TargetGroup_basic
=== PAUSE TestAccELBV2TargetGroup_basic
=== RUN   TestAccELBV2TargetGroup_udp
=== PAUSE TestAccELBV2TargetGroup_udp
=== RUN   TestAccELBV2TargetGroup_ForceNew_name
=== PAUSE TestAccELBV2TargetGroup_ForceNew_name
=== RUN   TestAccELBV2TargetGroup_ForceNew_port
=== PAUSE TestAccELBV2TargetGroup_ForceNew_port
=== RUN   TestAccELBV2TargetGroup_ForceNew_protocol
=== PAUSE TestAccELBV2TargetGroup_ForceNew_protocol
=== RUN   TestAccELBV2TargetGroup_ForceNew_vpc
=== PAUSE TestAccELBV2TargetGroup_ForceNew_vpc
=== RUN   TestAccELBV2TargetGroup_Defaults_application
=== PAUSE TestAccELBV2TargetGroup_Defaults_application
=== RUN   TestAccELBV2TargetGroup_Defaults_network
=== PAUSE TestAccELBV2TargetGroup_Defaults_network
=== RUN   TestAccELBV2TargetGroup_HealthCheck_enable
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_enable
=== RUN   TestAccELBV2TargetGroup_Name_generated
=== PAUSE TestAccELBV2TargetGroup_Name_generated
=== RUN   TestAccELBV2TargetGroup_Name_prefix
=== PAUSE TestAccELBV2TargetGroup_Name_prefix
=== RUN   TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
=== RUN   TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== PAUSE TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
=== RUN   TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== PAUSE TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
=== RUN   TestAccELBV2TargetGroup_preserveClientIPValid
=== PAUSE TestAccELBV2TargetGroup_preserveClientIPValid
=== RUN   TestAccELBV2TargetGroup_Geneve_basic
=== PAUSE TestAccELBV2TargetGroup_Geneve_basic
=== RUN   TestAccELBV2TargetGroup_Geneve_notSticky
=== PAUSE TestAccELBV2TargetGroup_Geneve_notSticky
=== RUN   TestAccELBV2TargetGroup_Geneve_Sticky
=== PAUSE TestAccELBV2TargetGroup_Geneve_Sticky
=== RUN   TestAccELBV2TargetGroup_Geneve_targetFailover
=== PAUSE TestAccELBV2TargetGroup_Geneve_targetFailover
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_defaultNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_invalidNLB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validALB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validALB
=== RUN   TestAccELBV2TargetGroup_Stickiness_validNLB
=== PAUSE TestAccELBV2TargetGroup_Stickiness_validNLB
=== RUN   TestAccELBV2TargetGroup_tags
=== PAUSE TestAccELBV2TargetGroup_tags
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_update
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_update
=== RUN   TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== PAUSE TestAccELBV2TargetGroup_Stickiness_updateEnabled
=== RUN   TestAccELBV2TargetGroup_HealthCheck_without
=== PAUSE TestAccELBV2TargetGroup_HealthCheck_without
=== RUN   TestAccELBV2TargetGroup_ALBAlias_basic
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_basic
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
=== RUN   TestAccELBV2TargetGroup_ALBAlias_generatedName
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_generatedName
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambda
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambda
=== RUN   TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
=== RUN   TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
=== RUN   TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_namePrefix
=== RUN   TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
=== RUN   TestAccELBV2TargetGroup_ALBAlias_tags
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_tags
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
=== RUN   TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== PAUSE TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
=== CONT  TestAccELBV2TargetGroup_backwardsCompatibility
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultALB
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changePortForceNew
--- PASS: TestAccELBV2TargetGroup_backwardsCompatibility (23.67s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_namePrefix
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultALB (24.01s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changePortForceNew (40.56s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType
--- PASS: TestAccELBV2TargetGroup_ALBAlias_namePrefix (23.78s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateStickinessEnabled (54.47s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_tags
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateHealthCheck (38.10s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart
--- PASS: TestAccELBV2TargetGroup_ALBAlias_updateLoadBalancingAlgorithmType (52.80s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateAppEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_tags (40.45s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_setAndUpdateSlowStart (40.43s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_basic
--- PASS: TestAccELBV2TargetGroup_ALBAlias_basic (22.05s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_without
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateAppEnabled (56.83s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_updateEnabled
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeNameForceNew (41.14s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_update
--- PASS: TestAccELBV2TargetGroup_HealthCheck_without (17.85s)
=== CONT  TestAccELBV2TargetGroup_Defaults_application
--- PASS: TestAccELBV2TargetGroup_Defaults_application (21.73s)
=== CONT  TestAccELBV2TargetGroup_Geneve_targetFailover
--- PASS: TestAccELBV2TargetGroup_HealthCheck_update (38.73s)
=== CONT  TestAccELBV2TargetGroup_Geneve_Sticky
--- PASS: TestAccELBV2TargetGroup_Stickiness_updateEnabled (54.28s)
=== CONT  TestAccELBV2TargetGroup_Geneve_notSticky
--- PASS: TestAccELBV2TargetGroup_Geneve_targetFailover (44.27s)
=== CONT  TestAccELBV2TargetGroup_Geneve_basic
--- PASS: TestAccELBV2TargetGroup_Geneve_Sticky (39.11s)
=== CONT  TestAccELBV2TargetGroup_preserveClientIPValid
--- PASS: TestAccELBV2TargetGroup_Geneve_notSticky (38.40s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy
--- PASS: TestAccELBV2TargetGroup_Geneve_basic (25.28s)
=== CONT  TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination
--- PASS: TestAccELBV2TargetGroup_preserveClientIPValid (36.95s)
=== CONT  TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated
--- PASS: TestAccELBV2TargetGroup_NetworkLB_targetGroupWithProxy (36.99s)
=== CONT  TestAccELBV2TargetGroup_Name_prefix
--- PASS: TestAccELBV2TargetGroup_networkLB_TargetGroupWithConnectionTermination (37.47s)
=== CONT  TestAccELBV2TargetGroup_Name_generated
--- PASS: TestAccELBV2TargetGroup_Name_prefix (22.25s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_enable
--- PASS: TestAccELBV2TargetGroup_NetworkLB_tcpHealthCheckUpdated (38.81s)
=== CONT  TestAccELBV2TargetGroup_Defaults_network
--- PASS: TestAccELBV2TargetGroup_Name_generated (22.84s)
=== CONT  TestAccELBV2TargetGroup_tags
--- PASS: TestAccELBV2TargetGroup_HealthCheck_enable (30.59s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidALB
--- PASS: TestAccELBV2TargetGroup_Defaults_network (23.97s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_invalidNLB
--- PASS: TestAccELBV2TargetGroup_tags (52.03s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validNLB
=== CONT  TestAccELBV2TargetGroup_Stickiness_defaultNLB
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidALB (40.12s)
--- PASS: TestAccELBV2TargetGroup_Stickiness_invalidNLB (36.34s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambda
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambda (19.33s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC
--- PASS: TestAccELBV2TargetGroup_ALBAlias_missingPortProtocolVPC (21.76s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled
--- PASS: TestAccELBV2TargetGroup_Stickiness_defaultNLB (54.10s)
=== CONT  TestAccELBV2TargetGroup_attrsOnCreate
--- PASS: TestAccELBV2TargetGroup_Stickiness_validNLB (73.11s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_vpc
--- PASS: TestAccELBV2TargetGroup_ALBAlias_lambdaMultiValueHeadersEnabled (49.34s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_protocol
--- PASS: TestAccELBV2TargetGroup_attrsOnCreate (39.00s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_port
--- PASS: TestAccELBV2TargetGroup_ForceNew_vpc (37.49s)
=== CONT  TestAccELBV2TargetGroup_ForceNew_name
--- PASS: TestAccELBV2TargetGroup_ForceNew_protocol (39.91s)
=== CONT  TestAccELBV2TargetGroup_udp
--- PASS: TestAccELBV2TargetGroup_ForceNew_port (39.05s)
=== CONT  TestAccELBV2TargetGroup_basic
--- PASS: TestAccELBV2TargetGroup_ForceNew_name (40.41s)
=== CONT  TestAccELBV2TargetGroup_Stickiness_validALB
--- PASS: TestAccELBV2TargetGroup_udp (20.91s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck
--- PASS: TestAccELBV2TargetGroup_basic (21.06s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcHealthCheck (20.90s)
=== CONT  TestAccELBV2TargetGroup_ProtocolVersion_basic
--- PASS: TestAccELBV2TargetGroup_Stickiness_validALB (37.78s)
=== CONT  TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_grpcUpdate (39.87s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew
--- PASS: TestAccELBV2TargetGroup_ProtocolVersion_basic (21.18s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_generatedName
--- PASS: TestAccELBV2TargetGroup_ALBAlias_generatedName (20.95s)
=== CONT  TestAccELBV2TargetGroup_tls
--- PASS: TestAccELBV2TargetGroup_HealthCheck_tcpHTTPS (38.39s)
=== CONT  TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeVPCForceNew (35.75s)
=== CONT  TestAccELBV2TargetGroup_ipAddressType
--- PASS: TestAccELBV2TargetGroup_tls (21.85s)
--- PASS: TestAccELBV2TargetGroup_ipAddressType (24.52s)
--- PASS: TestAccELBV2TargetGroup_ALBAlias_changeProtocolForceNew (39.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	640.664s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8117f74 into hashicorp:main Dec 8, 2022
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

This was referenced Dec 10, 2022
Open
Open
Open
Open
@johnsonaj johnsonaj mentioned this pull request Dec 22, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.46.0
Development

Successfully merging this pull request may close these issues.

aws_lb_target_group: Incorrect health check diffs/validations for NLB target groups
2 participants
@mattburgess @ewbankkit