Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudfront_distribution_zone_id to aws_cognito_user_pool_domain #27790

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
60f8fe2
Add cloudfront_distribution_zone_id parameter to aws_cognito_user_poo…
larstobi Nov 14, 2022
e2cb013
Update CHANGELOG.md
larstobi Nov 14, 2022
7770c8b
Fix formatting
larstobi Nov 14, 2022
e86eb6b
Revert "Fix formatting"
larstobi Nov 14, 2022
2b6ab2f
Revert "Update CHANGELOG.md"
larstobi Nov 14, 2022
d693401
Revert "Revert "Update CHANGELOG.md""
ewbankkit Mar 10, 2023
1c60824
Revert "Revert "Fix formatting""
ewbankkit Mar 10, 2023
e2e25b9
Revert "Fix formatting"
ewbankkit Mar 10, 2023
1a8f503
Revert "Update CHANGELOG.md"
ewbankkit Mar 10, 2023
25a95cf
Revert "Add cloudfront_distribution_zone_id parameter to aws_cognito_…
ewbankkit Mar 10, 2023
2915747
r/aws_cognito_user_pool_domain: Tidy up non-custom domain acceptance …
ewbankkit Mar 10, 2023
35ddb86
Merge branch 'main' into HEAD
ewbankkit Mar 10, 2023
836db02
r/aws_cognito_user_pool_domain: Add 'FindUserPoolDomain'.
ewbankkit Mar 10, 2023
3bb63b3
r/aws_cognito_user_pool_domain: Add 'cloudfront_distribution' attribute.
ewbankkit Mar 10, 2023
bd4df04
Add 'verify.CloudFrontDistributionHostedZoneIDForPartition'.
ewbankkit Mar 10, 2023
4f5dea0
Add 'AWSClient.CloudFrontDistributionHostedZoneID'.
ewbankkit Mar 10, 2023
497fb60
r/aws_cognito_user_pool_domain: Add 'cloudfront_distribution_zone_id'…
ewbankkit Mar 10, 2023
7170189
r/aws_cognito_user_pool_domain: Simplify 'TestAccCognitoIDPUserPoolDo…
ewbankkit Mar 10, 2023
2f5961a
CloudFront Distribution: Use 'AWSClient.CloudFrontDistributionHostedZ…
ewbankkit Mar 10, 2023
511fa87
r/aws_api_gateway_domain_name: Add 'FindDomainName'.
ewbankkit Mar 11, 2023
a751b9d
d/aws_api_gateway_domain_name: Use` 'FindDomainName'.
ewbankkit Mar 11, 2023
6311399
Fix terrafmt error.
ewbankkit Mar 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions internal/service/cognitoidp/user_pool_domain.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"time"

"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/endpoints"
"github.com/aws/aws-sdk-go/service/cognitoidentityprovider"
"github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
Expand All @@ -17,6 +18,15 @@ import (
"github.com/hashicorp/terraform-provider-aws/names"
)

// route53ZoneID defines the route 53 zone ID for CloudFront. This
// is used to set the zone_id attribute.
const route53ZoneID = "Z2FDTNDATAQYW2"

// cnRoute53ZoneID defines the route 53 zone ID for CloudFront in AWS CN.
// This is used to set the zone_id attribute.
// ref: https://docs.amazonaws.cn/en_us/aws/latest/userguide/route53.html
const cnRoute53ZoneID = "Z3RFFRIM2A3IF5"

func ResourceUserPoolDomain() *schema.Resource {
return &schema.Resource{
Create: resourceUserPoolDomainCreate,
Expand Down Expand Up @@ -52,6 +62,10 @@ func ResourceUserPoolDomain() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"cloudfront_distribution_zone_id": {
Type: schema.TypeString,
Computed: true,
},
"s3_bucket": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -136,6 +150,15 @@ func resourceUserPoolDomainRead(d *schema.ResourceData, meta interface{}) error
}
d.Set("aws_account_id", desc.AWSAccountId)
d.Set("cloudfront_distribution_arn", desc.CloudFrontDistribution)

// override hosted_zone_id from flattenDistributionConfig
region := meta.(*conns.AWSClient).Region
if v, ok := endpoints.PartitionForRegion(endpoints.DefaultPartitions(), region); ok && v.ID() == endpoints.AwsCnPartitionID {
d.Set("cloudfront_distribution_zone_id", cnRoute53ZoneID)
} else {
d.Set("cloudfront_distribution_zone_id", route53ZoneID)
}

d.Set("s3_bucket", desc.S3Bucket)
d.Set("user_pool_id", desc.UserPoolId)
d.Set("version", desc.Version)
Expand Down
1 change: 1 addition & 0 deletions internal/service/cognitoidp/user_pool_domain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ func TestAccCognitoIDPUserPoolDomain_basic(t *testing.T) {
resource.TestCheckResourceAttr("aws_cognito_user_pool.main", "name", poolName),
resource.TestCheckResourceAttrSet("aws_cognito_user_pool_domain.main", "aws_account_id"),
resource.TestCheckResourceAttrSet("aws_cognito_user_pool_domain.main", "cloudfront_distribution_arn"),
resource.TestCheckResourceAttr("aws_cognito_user_pool_domain.main", "cloudfront_distribution_zone_id", "Z2FDTNDATAQYW2"),
resource.TestCheckResourceAttrSet("aws_cognito_user_pool_domain.main", "s3_bucket"),
resource.TestCheckResourceAttrSet("aws_cognito_user_pool_domain.main", "version"),
),
Expand Down
5 changes: 2 additions & 3 deletions website/docs/r/cognito_user_pool_domain.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ resource "aws_route53_record" "auth-cognito-A" {
zone_id = data.aws_route53_zone.example.zone_id
alias {
evaluate_target_health = false
name = aws_cognito_user_pool_domain.main.cloudfront_distribution_arn
# This zone_id is fixed
zone_id = "Z2FDTNDATAQYW2"
name = aws_cognito_user_pool_domain.main.cloudfront_distribution_arn
zone_id = aws_cognito_user_pool_domain.main.cloudfront_distribution_zone_id
}
}
```
Expand Down