-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validation rule in appstream stack resource #27744
Update validation rule in appstream stack resource #27744
Conversation
Redirect URL did have a maximum length of 100, but should be 1000
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=appstream TESTS=TestAccAppStreamStack_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 2 -run='TestAccAppStreamStack_' -timeout 180m
=== RUN TestAccAppStreamStack_basic
=== PAUSE TestAccAppStreamStack_basic
=== RUN TestAccAppStreamStack_disappears
=== PAUSE TestAccAppStreamStack_disappears
=== RUN TestAccAppStreamStack_complete
=== PAUSE TestAccAppStreamStack_complete
=== RUN TestAccAppStreamStack_applicationSettings_basic
=== PAUSE TestAccAppStreamStack_applicationSettings_basic
=== RUN TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== RUN TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== RUN TestAccAppStreamStack_withTags
=== PAUSE TestAccAppStreamStack_withTags
=== CONT TestAccAppStreamStack_basic
=== CONT TestAccAppStreamStack_applicationSettings_removeFromEnabled
--- PASS: TestAccAppStreamStack_basic (17.36s)
=== CONT TestAccAppStreamStack_complete
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromEnabled (28.63s)
=== CONT TestAccAppStreamStack_applicationSettings_basic
--- PASS: TestAccAppStreamStack_complete (29.38s)
=== CONT TestAccAppStreamStack_disappears
--- PASS: TestAccAppStreamStack_disappears (12.45s)
=== CONT TestAccAppStreamStack_withTags
--- PASS: TestAccAppStreamStack_applicationSettings_basic (43.13s)
=== CONT TestAccAppStreamStack_applicationSettings_removeFromDisabled
--- PASS: TestAccAppStreamStack_withTags (29.26s)
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromDisabled (21.03s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appstream 95.417s
Nice find, @pierskarsenbarg! Thanks for your contribution 👏 |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Increase max length of redirectUrl in appstream stack resource. Docs specify that max length is 1000: https://docs.aws.amazon.com/appstream2/latest/APIReference/API_CreateStack.html#AppStream2-CreateStack-request-RedirectURL
Relations
Fixes #27743
References
Output from Acceptance Testing