Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi_party_conference_enabled to aws_connect_instance #27734

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

schuylr
Copy link
Contributor

@schuylr schuylr commented Nov 9, 2022

Description

Add the multi_party_conference_enabled argument to the aws_connect_instance resource, as well as the multi_party_conference_enabled attribute to the same data source.

Relations

Closes #27728

References

https://docs.aws.amazon.com/connect/latest/adminguide/multi-party-calls.html
https://docs.aws.amazon.com/connect/latest/APIReference/API_UpdateInstanceAttribute.html

Output from Acceptance Testing

terraform-provider-aws % make testacc TESTARGS='-run=TestAccConnect_serial/Instance/basic' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/Instance/basic -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/Instance
=== RUN   TestAccConnect_serial/Instance/basic
=== RUN   TestAccConnect_serial/Instance/dataSource_basic
=== RUN   TestAccConnect_serial/InstanceStorageConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/basic
--- PASS: TestAccConnect_serial (328.13s)
    --- PASS: TestAccConnect_serial/Instance (234.96s)
        --- PASS: TestAccConnect_serial/Instance/basic (110.64s)
        --- PASS: TestAccConnect_serial/Instance/dataSource_basic (124.32s)
    --- PASS: TestAccConnect_serial/InstanceStorageConfig (93.17s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (93.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	332.470s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/connect Issues and PRs that pertain to the connect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Nov 9, 2022
Copy link
Contributor

@sasidhar-aws sasidhar-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 10, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccConnect_serial/Instance/basic' PKG=connect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/connect/... -v -count 1 -parallel 20  -run=TestAccConnect_serial/Instance/basic -timeout 180m
=== RUN   TestAccConnect_serial
=== RUN   TestAccConnect_serial/Instance
=== RUN   TestAccConnect_serial/Instance/basic
=== RUN   TestAccConnect_serial/Instance/dataSource_basic
=== RUN   TestAccConnect_serial/InstanceStorageConfig
=== RUN   TestAccConnect_serial/InstanceStorageConfig/basic
--- PASS: TestAccConnect_serial (320.27s)
    --- PASS: TestAccConnect_serial/Instance (231.07s)
        --- PASS: TestAccConnect_serial/Instance/basic (106.46s)
        --- PASS: TestAccConnect_serial/Instance/dataSource_basic (124.61s)
    --- PASS: TestAccConnect_serial/InstanceStorageConfig (89.20s)
        --- PASS: TestAccConnect_serial/InstanceStorageConfig/basic (89.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	324.742s

@ewbankkit
Copy link
Contributor

@schuylr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8f75bc4 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@schuylr schuylr deleted the f-connect_multi_party_conference branch November 14, 2022 13:44
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/connect Issues and PRs that pertain to the connect service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add Multi Party conference as part of existing Amazon connect instance
4 participants