Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Resolve import issues on aws_lb_target_group when specifying ip_address_type of ipv4 #27464

Merged

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Oct 25, 2022

Description

Adds the reading and setting of the ip_address_type value during the resource read.

Relations

Closes #27463

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccELBV2TargetGroup_ipAddressType' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2TargetGroup_ipAddressType -timeout 180m
=== RUN   TestAccELBV2TargetGroup_ipAddressType
=== PAUSE TestAccELBV2TargetGroup_ipAddressType
=== CONT  TestAccELBV2TargetGroup_ipAddressType
--- PASS: TestAccELBV2TargetGroup_ipAddressType (22.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      23.960s

...

* add set for "ip_address_type"
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2022
@bschaatsbergen
Copy link
Member

Good spot @brittandeyoung

@brittandeyoung brittandeyoung changed the title [WIP] BugFix: Resolve import issues on aws_lightsail_static_ip when specifying ip_address_type of ipv4 [WIP] BugFix: Resolve import issues on aws_lb_target_group when specifying ip_address_type of ipv4 Oct 25, 2022
Update TestAccELBV2TargetGroup_ipAddressType to test imports
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 25, 2022
@brittandeyoung brittandeyoung changed the title [WIP] BugFix: Resolve import issues on aws_lb_target_group when specifying ip_address_type of ipv4 BugFix: Resolve import issues on aws_lb_target_group when specifying ip_address_type of ipv4 Oct 25, 2022
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 25, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2TargetGroup_ipAddressType' PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2TargetGroup_ipAddressType -timeout 180m
=== RUN   TestAccELBV2TargetGroup_ipAddressType
=== PAUSE TestAccELBV2TargetGroup_ipAddressType
=== CONT  TestAccELBV2TargetGroup_ipAddressType
--- PASS: TestAccELBV2TargetGroup_ipAddressType (24.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	29.494s

@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e3c56e8 into hashicorp:main Oct 25, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 25, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: resource/aws_lb_target_group - Forces replacement of resource after importing
3 participants