-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource] aws_identitystore_group_membership #26944
[New Resource] aws_identitystore_group_membership #26944
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @bengisc 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few drive by comments; nice work so far.
…-trailing-newline Files should end with a single newline character'.
…erent types are not allowed in the same group'.
…ing file frontmatter: error parsing YAML frontmatter: yaml: line 7: could not find expected ':'".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIdentityStoreGroupMembership_' PKG=identitystore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/identitystore/... -v -count 1 -parallel 2 -run=TestAccIdentityStoreGroupMembership_ -timeout 180m
=== RUN TestAccIdentityStoreGroupMembership_basic
=== PAUSE TestAccIdentityStoreGroupMembership_basic
=== RUN TestAccIdentityStoreGroupMembership_disappears
=== PAUSE TestAccIdentityStoreGroupMembership_disappears
=== RUN TestAccIdentityStoreGroupMembership_GroupId
=== PAUSE TestAccIdentityStoreGroupMembership_GroupId
=== RUN TestAccIdentityStoreGroupMembership_MemberId
=== PAUSE TestAccIdentityStoreGroupMembership_MemberId
=== CONT TestAccIdentityStoreGroupMembership_basic
=== CONT TestAccIdentityStoreGroupMembership_GroupId
--- PASS: TestAccIdentityStoreGroupMembership_basic (22.57s)
=== CONT TestAccIdentityStoreGroupMembership_MemberId
--- PASS: TestAccIdentityStoreGroupMembership_GroupId (38.89s)
=== CONT TestAccIdentityStoreGroupMembership_disappears
--- PASS: TestAccIdentityStoreGroupMembership_disappears (17.15s)
--- PASS: TestAccIdentityStoreGroupMembership_MemberId (36.39s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/identitystore 62.995s
@bengisc Thanks for the contribution 🎉 👏. There must have been some glitch with the PR labeler GitHub Action that caused all those labels to be added. |
This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Closes #26939.
Relates #26948.
Relates #26674.
Output from acceptance testing: