Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(resourcegroups): Add configuration type and attribute #26934

Merged
merged 14 commits into from
Oct 20, 2022
Merged

enhancement(resourcegroups): Add configuration type and attribute #26934

merged 14 commits into from
Oct 20, 2022

Commits on Sep 22, 2022

  1. Support configuration type resource groups

    @IainSteers
    IainSteers committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e63246e View commit details
    Browse the repository at this point in the history

  2. Add acceptance tests for configuration resource groups

    @IainSteers
    IainSteers committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    85624f1 View commit details
    Browse the repository at this point in the history

  3. Add Changelog for PR 26934

    @IainSteers
    IainSteers committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    31dc757 View commit details
    Browse the repository at this point in the history

  4. Fix import order and usage lint

    @IainSteers
    IainSteers committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    9de3a59 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Format test terraform blocks

    @IainSteers
    IainSteers committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    fcef7db View commit details
    Browse the repository at this point in the history

  2. r/aws_resourcegroups_group: Alphabetize attributes.

    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    05d9eb1 View commit details
    Browse the repository at this point in the history

  3. r/aws_resourcegroups_group: Order CRUD handlers.

    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    b64acd6 View commit details
    Browse the repository at this point in the history

  4. r/aws_resourcegroups_group: Add 'FindGroupByName'. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2  -run=TestAccResourceGroupsGroup_ -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
--- PASS: TestAccResourceGroupsGroup_basic (34.23s)
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_Configuration (58.01s)
--- PASS: TestAccResourceGroupsGroup_tags (46.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	84.833s
    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    62e36c6 View commit details
    Browse the repository at this point in the history

  5. r/aws_resourcegroups_group: Tidy up 'waitGroupConfigurationUpdated'. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2  -run=TestAccResourceGroupsGroup_ -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
--- PASS: TestAccResourceGroupsGroup_basic (34.75s)
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_Configuration (56.45s)
--- PASS: TestAccResourceGroupsGroup_tags (44.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	83.145s
    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e9bd759 View commit details
    Browse the repository at this point in the history

  6. r/aws_resourcegroups_group: Switch to 'WithoutTimeout' CRUD handlers (h… 

    …ashicorp#15090).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2  -run=TestAccResourceGroupsGroup_ -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
--- PASS: TestAccResourceGroupsGroup_basic (32.33s)
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_Configuration (53.89s)
--- PASS: TestAccResourceGroupsGroup_tags (43.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	79.452s
    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e53df5b View commit details
    Browse the repository at this point in the history

  7. r/aws_resourcegroups_group: Tidy up acceptance tests. 

    Acceptance test output:

% make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2  -run=TestAccResourceGroupsGroup_ -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
--- PASS: TestAccResourceGroupsGroup_basic (34.17s)
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_Configuration (56.72s)
--- PASS: TestAccResourceGroupsGroup_tags (45.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	83.659s
    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    176a4a0 View commit details
    Browse the repository at this point in the history

  8. Tweak CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    4e65e1f View commit details
    Browse the repository at this point in the history

  9. Document 'configuration' block.

    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6de5bd1 View commit details
    Browse the repository at this point in the history

  10. Fix golangi-lint 'unparam'.

    @ewbankkit
    ewbankkit committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d08ff90 View commit details
    Browse the repository at this point in the history