Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for rolesanywhere #26858

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Fix typo for rolesanywhere #26858

merged 5 commits into from
Sep 30, 2022

Conversation

cjsrkd3321
Copy link
Contributor

@cjsrkd3321 cjsrkd3321 commented Sep 19, 2022

Hello!
Fix typo for rolesanywhere's profile.

Please check my PR. thank you.

Fixes #26872

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. labels Sep 19, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @cjsrkd3321 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@cjsrkd3321 cjsrkd3321 changed the title Fix typo for rolesanywhere's profile Fix typo for rolesanywhere Sep 20, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 20, 2022
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Sep 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRolesAnywhereProfile_' PKG=rolesanywhere ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rolesanywhere/... -v -count 1 -parallel 2  -run=TestAccRolesAnywhereProfile_ -timeout 180m
=== RUN   TestAccRolesAnywhereProfile_basic
=== PAUSE TestAccRolesAnywhereProfile_basic
=== RUN   TestAccRolesAnywhereProfile_tags
=== PAUSE TestAccRolesAnywhereProfile_tags
=== RUN   TestAccRolesAnywhereProfile_disappears
=== PAUSE TestAccRolesAnywhereProfile_disappears
=== RUN   TestAccRolesAnywhereProfile_enabled
=== PAUSE TestAccRolesAnywhereProfile_enabled
=== CONT  TestAccRolesAnywhereProfile_basic
=== CONT  TestAccRolesAnywhereProfile_disappears
--- PASS: TestAccRolesAnywhereProfile_disappears (18.59s)
=== CONT  TestAccRolesAnywhereProfile_tags
--- PASS: TestAccRolesAnywhereProfile_basic (21.76s)
=== CONT  TestAccRolesAnywhereProfile_enabled
--- PASS: TestAccRolesAnywhereProfile_tags (48.88s)
--- PASS: TestAccRolesAnywhereProfile_enabled (47.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	74.071s
% make testacc TESTARGS='-run=TestAccRolesAnywhereTrustAnchor_enabled' PKG=rolesanywhere ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rolesanywhere/... -v -count 1 -parallel 2  -run=TestAccRolesAnywhereTrustAnchor_enabled -timeout 180m
=== RUN   TestAccRolesAnywhereTrustAnchor_enabled
=== PAUSE TestAccRolesAnywhereTrustAnchor_enabled
=== CONT  TestAccRolesAnywhereTrustAnchor_enabled
--- PASS: TestAccRolesAnywhereTrustAnchor_enabled (43.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rolesanywhere	47.041s

@ewbankkit
Copy link
Contributor

@cjsrkd3321 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d7dbeab into hashicorp:main Sep 30, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rolesanywhere Issues and PRs that pertain to the rolesanywhere service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix typo and type string to bool for rolesanywhere
3 participants