Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PartitionKey and ClusteringKey Types in Schema #26812

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

michaelraney
Copy link
Contributor

@michaelraney michaelraney commented Sep 15, 2022

In Cassandra and Amazon Keyspaces, the order of column names in a partition key and clustering key should be ordered and not changed. Today, the schema type is unordered creating issues when creating and maintaining resources. This change switches type to a list schema type which is ordered.

https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_logical.html

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26276.

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

In Cassandra and Amazon Keyspaces, the order of column names in a partition key and clustering key should be ordered and not changed. Today, the schema type is unordered creating issues when creating and maintaining resources. This change switches type to a list schema type which is ordered.
@github-actions github-actions bot added service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Sep 15, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 28, 2022
@rctunisi
Copy link

how can i help prioritize this issue?

@rctunisi
Copy link

@ewbankkit any previews on this bugfix?? will be available soon??

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccKeyspacesTable_' PKG=keyspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2  -run=TestAccKeyspacesTable_ -timeout 180m
=== RUN   TestAccKeyspacesTable_basic
=== PAUSE TestAccKeyspacesTable_basic
=== RUN   TestAccKeyspacesTable_disappears
=== PAUSE TestAccKeyspacesTable_disappears
=== RUN   TestAccKeyspacesTable_tags
=== PAUSE TestAccKeyspacesTable_tags
=== RUN   TestAccKeyspacesTable_multipleColumns
=== PAUSE TestAccKeyspacesTable_multipleColumns
=== RUN   TestAccKeyspacesTable_update
=== PAUSE TestAccKeyspacesTable_update
=== RUN   TestAccKeyspacesTable_addColumns
=== PAUSE TestAccKeyspacesTable_addColumns
=== RUN   TestAccKeyspacesTable_delColumns
=== PAUSE TestAccKeyspacesTable_delColumns
=== CONT  TestAccKeyspacesTable_basic
=== CONT  TestAccKeyspacesTable_update
--- PASS: TestAccKeyspacesTable_basic (105.11s)
=== CONT  TestAccKeyspacesTable_tags
--- PASS: TestAccKeyspacesTable_tags (130.24s)
=== CONT  TestAccKeyspacesTable_multipleColumns
--- PASS: TestAccKeyspacesTable_multipleColumns (104.78s)
=== CONT  TestAccKeyspacesTable_delColumns
--- PASS: TestAccKeyspacesTable_delColumns (149.12s)
=== CONT  TestAccKeyspacesTable_addColumns
--- PASS: TestAccKeyspacesTable_update (610.63s)
=== CONT  TestAccKeyspacesTable_disappears
--- PASS: TestAccKeyspacesTable_addColumns (129.31s)
--- PASS: TestAccKeyspacesTable_disappears (101.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	716.452s

@ewbankkit
Copy link
Contributor

@michaelraney Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2c07d5c into hashicorp:main Sep 30, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Sep 30, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_keyspaces_table specify clustering column order
3 participants