-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PartitionKey and ClusteringKey Types in Schema #26812
Conversation
In Cassandra and Amazon Keyspaces, the order of column names in a partition key and clustering key should be ordered and not changed. Today, the schema type is unordered creating issues when creating and maintaining resources. This change switches type to a list schema type which is ordered.
how can i help prioritize this issue? |
@ewbankkit any previews on this bugfix?? will be available soon?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccKeyspacesTable_' PKG=keyspaces ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run=TestAccKeyspacesTable_ -timeout 180m
=== RUN TestAccKeyspacesTable_basic
=== PAUSE TestAccKeyspacesTable_basic
=== RUN TestAccKeyspacesTable_disappears
=== PAUSE TestAccKeyspacesTable_disappears
=== RUN TestAccKeyspacesTable_tags
=== PAUSE TestAccKeyspacesTable_tags
=== RUN TestAccKeyspacesTable_multipleColumns
=== PAUSE TestAccKeyspacesTable_multipleColumns
=== RUN TestAccKeyspacesTable_update
=== PAUSE TestAccKeyspacesTable_update
=== RUN TestAccKeyspacesTable_addColumns
=== PAUSE TestAccKeyspacesTable_addColumns
=== RUN TestAccKeyspacesTable_delColumns
=== PAUSE TestAccKeyspacesTable_delColumns
=== CONT TestAccKeyspacesTable_basic
=== CONT TestAccKeyspacesTable_update
--- PASS: TestAccKeyspacesTable_basic (105.11s)
=== CONT TestAccKeyspacesTable_tags
--- PASS: TestAccKeyspacesTable_tags (130.24s)
=== CONT TestAccKeyspacesTable_multipleColumns
--- PASS: TestAccKeyspacesTable_multipleColumns (104.78s)
=== CONT TestAccKeyspacesTable_delColumns
--- PASS: TestAccKeyspacesTable_delColumns (149.12s)
=== CONT TestAccKeyspacesTable_addColumns
--- PASS: TestAccKeyspacesTable_update (610.63s)
=== CONT TestAccKeyspacesTable_disappears
--- PASS: TestAccKeyspacesTable_addColumns (129.31s)
--- PASS: TestAccKeyspacesTable_disappears (101.71s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces 716.452s
@michaelraney Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
In Cassandra and Amazon Keyspaces, the order of column names in a partition key and clustering key should be ordered and not changed. Today, the schema type is unordered creating issues when creating and maintaining resources. This change switches type to a list schema type which is ordered.
https://cassandra.apache.org/doc/latest/cassandra/data_modeling/data_modeling_logical.html
Community Note
Closes #26276.
Output from acceptance testing: