Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual stack support for Amazon Aurora #26489

Merged

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    82a538b View commit details
    Browse the repository at this point in the history
  2. Create 26489.txt

    bschaatsbergen committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8446227 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Configuration menu
    Copy the full SHA
    46ee86f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9605f61 View commit details
    Browse the repository at this point in the history
  3. strip off the 1

    bschaatsbergen committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2e37b1d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1a1c70b View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Configuration menu
    Copy the full SHA
    862b6b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    070a0db View commit details
    Browse the repository at this point in the history
  3. Update 26489.txt

    bschaatsbergen committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    85cab00 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8aec46 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Tweak CHANGELOG entry.

    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2371979 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43d8963 View commit details
    Browse the repository at this point in the history
  3. r/aws_rds_cluster: Tidy up resource Delete.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
    === RUN   TestAccRDSCluster_basic
    === PAUSE TestAccRDSCluster_basic
    === CONT  TestAccRDSCluster_basic
    --- PASS: TestAccRDSCluster_basic (161.34s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	165.297s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    bc8b519 View commit details
    Browse the repository at this point in the history
  4. r/aws_rds_cluster: Tidy up resource Read.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
    === RUN   TestAccRDSCluster_basic
    === PAUSE TestAccRDSCluster_basic
    === CONT  TestAccRDSCluster_basic
    --- PASS: TestAccRDSCluster_basic (173.13s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	177.144s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c6f6ba5 View commit details
    Browse the repository at this point in the history
  5. r/aws_rds_cluster: Add 'TestAccRDSCluster_disappears' (hashicorp#13826).

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_disappears' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_disappears -timeout 180m
    === RUN   TestAccRDSCluster_disappears
    === PAUSE TestAccRDSCluster_disappears
    === CONT  TestAccRDSCluster_disappears
    --- PASS: TestAccRDSCluster_disappears (106.05s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	110.200s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b9189c6 View commit details
    Browse the repository at this point in the history
  6. r/aws_rds_cluster: 'WaitForClusterDeletion' -> 'waitDBClusterDeleted'.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic -timeout 180m
    === RUN   TestAccRDSCluster_basic
    === PAUSE TestAccRDSCluster_basic
    === CONT  TestAccRDSCluster_basic
    --- PASS: TestAccRDSCluster_basic (169.79s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	176.258s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6caf6a5 View commit details
    Browse the repository at this point in the history
  7. r/aws_rds_cluster: Tidy up resource Create.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_s3Restore\|TestAccRDSCluster_pointInTimeRestore\|TestAccRDSCluster_updateIAMRoles\|TestAccRDSCluster_snapshotIdentifier' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_basic\|TestAccRDSCluster_s3Restore\|TestAccRDSCluster_pointInTimeRestore\|TestAccRDSCluster_updateIAMRoles\|TestAccRDSCluster_snapshotIdentifier -timeout 180m
    === RUN   TestAccRDSCluster_basic
    === PAUSE TestAccRDSCluster_basic
    === RUN   TestAccRDSCluster_s3Restore
    === PAUSE TestAccRDSCluster_s3Restore
    === RUN   TestAccRDSCluster_pointInTimeRestore
    === PAUSE TestAccRDSCluster_pointInTimeRestore
    === RUN   TestAccRDSCluster_updateIAMRoles
    === PAUSE TestAccRDSCluster_updateIAMRoles
    === RUN   TestAccRDSCluster_snapshotIdentifier
    === PAUSE TestAccRDSCluster_snapshotIdentifier
    === CONT  TestAccRDSCluster_basic
    === CONT  TestAccRDSCluster_updateIAMRoles
    --- PASS: TestAccRDSCluster_basic (161.33s)
    === CONT  TestAccRDSCluster_pointInTimeRestore
    --- PASS: TestAccRDSCluster_updateIAMRoles (168.23s)
    === CONT  TestAccRDSCluster_snapshotIdentifier
    --- PASS: TestAccRDSCluster_snapshotIdentifier (358.47s)
    === CONT  TestAccRDSCluster_s3Restore
    --- PASS: TestAccRDSCluster_pointInTimeRestore (371.90s)
    === CONT  TestAccRDSCluster_s3Restore
        cluster_test.go:546: Step 1/1 error: Error running apply: exit status 1
    
            Error: waiting for RDS Cluster (tf-test-20220906170825745800000001) create: unexpected state 'migration-failed', wanted target 'available'. last error: %!s(<nil>)
    
              with aws_rds_cluster.test,
              on terraform_plugin_test.tf line 74, in resource "aws_rds_cluster" "test":
              74: resource "aws_rds_cluster" "test" {
    
    --- FAIL: TestAccRDSCluster_s3Restore (1558.92s)
    FAIL
    FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2089.773s
    FAIL
    make: *** [testacc] Error 1
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    386649a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eb220bd View commit details
    Browse the repository at this point in the history
  9. r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_takeFinalSnapshot'.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_takeFinalSnapshot' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_takeFinalSnapshot -timeout 180m
    === RUN   TestAccRDSCluster_takeFinalSnapshot
    === PAUSE TestAccRDSCluster_takeFinalSnapshot
    === CONT  TestAccRDSCluster_takeFinalSnapshot
    --- PASS: TestAccRDSCluster_takeFinalSnapshot (179.72s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	184.293s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2c9a94f View commit details
    Browse the repository at this point in the history
  10. r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_identifierGenerated' an…

    …d 'TestAccRDSCluster_identifierPrefix'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_identifierGenerated\|TestAccRDSCluster_identifierPrefix' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_identifierGenerated\|TestAccRDSCluster_identifierPrefix -timeout 180m
    === RUN   TestAccRDSCluster_identifierGenerated
    === PAUSE TestAccRDSCluster_identifierGenerated
    === RUN   TestAccRDSCluster_identifierPrefix
    === PAUSE TestAccRDSCluster_identifierPrefix
    === CONT  TestAccRDSCluster_identifierGenerated
    === CONT  TestAccRDSCluster_identifierPrefix
    --- PASS: TestAccRDSCluster_identifierPrefix (151.61s)
    --- PASS: TestAccRDSCluster_identifierGenerated (151.63s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	155.759s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    fd09c5a View commit details
    Browse the repository at this point in the history
  11. r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_availabilityZones', 'Te…

    …stAccRDSCluster_dbSubnetGroupName' and 'TestAccRDSCluster_pointInTimeRestore'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_dbSubnetGroupName\|TestAccRDSCluster_pointInTimeRestore' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_availabilityZones\|TestAccRDSCluster_dbSubnetGroupName\|TestAccRDSCluster_pointInTimeRestore -timeout 180m
    === RUN   TestAccRDSCluster_availabilityZones
    === PAUSE TestAccRDSCluster_availabilityZones
    === RUN   TestAccRDSCluster_dbSubnetGroupName
    === PAUSE TestAccRDSCluster_dbSubnetGroupName
    === RUN   TestAccRDSCluster_pointInTimeRestore
    === PAUSE TestAccRDSCluster_pointInTimeRestore
    === CONT  TestAccRDSCluster_availabilityZones
    === CONT  TestAccRDSCluster_pointInTimeRestore
    --- PASS: TestAccRDSCluster_availabilityZones (142.59s)
    === CONT  TestAccRDSCluster_dbSubnetGroupName
    --- PASS: TestAccRDSCluster_dbSubnetGroupName (163.82s)
    --- PASS: TestAccRDSCluster_pointInTimeRestore (355.39s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	359.505s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ad4bd8f View commit details
    Browse the repository at this point in the history
  12. r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_PointInTimeRestore_enab…

    …ledCloudWatchLogsExports', 'TestAccRDSCluster_networkType' and 'TestAccRDSCluster_EngineMode_multiMaster'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports\|TestAccRDSCluster_networkType\|TestAccRDSCluster_EngineMode_multiMaster' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports\|TestAccRDSCluster_networkType\|TestAccRDSCluster_EngineMode_multiMaster -timeout 180m
    === RUN   TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
    === PAUSE TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
    === RUN   TestAccRDSCluster_networkType
    === PAUSE TestAccRDSCluster_networkType
    === RUN   TestAccRDSCluster_EngineMode_multiMaster
    === PAUSE TestAccRDSCluster_EngineMode_multiMaster
    === CONT  TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports
    === CONT  TestAccRDSCluster_EngineMode_multiMaster
    --- PASS: TestAccRDSCluster_EngineMode_multiMaster (179.05s)
    === CONT  TestAccRDSCluster_networkType
    --- PASS: TestAccRDSCluster_PointInTimeRestore_enabledCloudWatchLogsExports (331.96s)
    --- PASS: TestAccRDSCluster_networkType (275.56s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	458.717s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8ade83b View commit details
    Browse the repository at this point in the history
  13. r/aws_rds_cluster: Tidy up 'TestAccRDSCluster_ReplicationSourceIdenti…

    …fier_kmsKeyID'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID -timeout 180m
    === RUN   TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
    === PAUSE TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
    === CONT  TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID
    --- PASS: TestAccRDSCluster_ReplicationSourceIdentifier_kmsKeyID (1574.73s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1578.477s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e39d54a View commit details
    Browse the repository at this point in the history
  14. r/aws_rds_cluster_instance: Test 'network_type' in 'TestAccRDSCluster…

    …Instance_basic'.
    
    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSClusterInstance_basic' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterInstance_basic -timeout 180m
    === RUN   TestAccRDSClusterInstance_basic
    === PAUSE TestAccRDSClusterInstance_basic
    === CONT  TestAccRDSClusterInstance_basic
    --- PASS: TestAccRDSClusterInstance_basic (794.60s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	798.711s
    ewbankkit committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2c715b8 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Configuration menu
    Copy the full SHA
    b23e084 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47dae12 View commit details
    Browse the repository at this point in the history
  3. d/aws_rds_cluster: Add 'network_type' attribute.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccRDSClusterDataSource_' PKG=rds ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSClusterDataSource_ -timeout 180m
    === RUN   TestAccRDSClusterDataSource_basic
    === PAUSE TestAccRDSClusterDataSource_basic
    === CONT  TestAccRDSClusterDataSource_basic
    --- PASS: TestAccRDSClusterDataSource_basic (135.58s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	140.333s
    ewbankkit committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e35f649 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94efb6a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1440807 View commit details
    Browse the repository at this point in the history
  6. Fix terrafmt error.

    ewbankkit committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    083fbdc View commit details
    Browse the repository at this point in the history