New Resource: aws_lex_resources

[jzbruno]

Fixes Issue #905

[radeksimko]

Hi @jzbruno
thanks for submitting the PR.

Do you mind raising a separate PR for all the /vendor changes? That will help avoiding conflicts as you work on the PR and also make review much easier.

[jzbruno]

Sure. I'll break the vendoring out into it's own PR.

[jzbruno]

@radeksimko I have created pull request #2650 to add vendoring for Lex.

[giancarlopetrini]

any update on this? It'd be such a help to have the lex resources available in the default binary! Thanks for working on this @jzbruno

[jzbruno]

@giancarlopetrini I will review what is left to finish after work and work on it this weekend.

[jzbruno]

Looks like I have the framework for most resources done but need to finish code, tests, and documentation. I will see what I can get done on Saturday.

Question: This is going to be a fairly large addition, should I break it up into a few PRs?

[bflad]

Generally speaking we prefer 1 resource/data source per PR just to make the reviewing process easier. Also since Lex is a new service, if you want make the aws/config.go change its own PR I can turbo merge that for you so you don't need to awkwardly include the same change in the two resource PRs.

[jzbruno]

Ok. I will break it up. There will end up being 4 resources.

• aws_lex_bot
• aws_lex_bot_alias
• aws_lex_intent
• aws_lex_slot_type

With aws_lex_intent being the most complex.

[jzbruno]

@bflad I created PR #3908 for the aws/config.go change. I will update this PR to just have aws_lex_bot.

[jzbruno]

Ok. This is ready for review. I will work on the other resources tonight and create PRs for each of them.

~/go/src/github.com/terraform-providers/terraform-provider-aws $ make fmt && make build
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
go install
~/go/src/github.com/terraform-providers/terraform-provider-aws $ cd aws/
~/go/src/github.com/terraform-providers/terraform-provider-aws/aws $ AWS_PROFILE=jzbruno AWS_DEFAULT_REGION=us-east-1 TF_ACC=1 go test -v -run TestAccLexBot
=== RUN   TestAccLexBot
--- PASS: TestAccLexBot (22.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	22.573s
~/go/src/github.com/terraform-providers/terraform-provider-aws/aws $ AWS_PROFILE=jzbruno AWS_DEFAULT_REGION=us-east-1 TF_ACC=1 go test -v -run TestAccDataSourceLexBot
=== RUN   TestAccDataSourceLexBot
--- PASS: TestAccDataSourceLexBot (15.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.289s

[dee-kryvenko]

Any reason this is not merged yet?

[JoshiiSinfield]

Hi @jzbruno,

Any update on this? We'd really like to use these resources.

Cheers,
Josh

[jzbruno]

Hi @JoshiiSinfield

I need to finish aws_lex_intent. The others have PRs and are waiting for review. If I remember right they should be reviewed in order.

• New Resource: aws_lex_resources #2616
• New Resource: aws_lex_slot_type #3936
• New Resource: aws_lex_bot_alias #4006

[nmarchini]

We'd love to see this released soon. Any news please?

[jzbruno]

For whoever is going to review this. Would it be easier if I combined the PRs? And I will work on finishing the intent resource this weekend.

[kmcquade]

+1

[jzbruno]

I have updated this branch to match the contribution guidelines and updated with the latest master branch. I will work on breaking apart the PR next.

[jzbruno]

The Lex slot type resource and data source PR #8916 is ready for review. I am going to try and keep each PR independent and just deal with merge conflicts as each one is merged.

[jzbruno]

@nywilken All PRs are ready for review. They can be reviewed independently but it would be best if they are merged in order.

1. Add Lex slot type data source and resource #8916
2. Add Lex intent data source and resource #8917
3. Add Lex bot data source and resoruce #8918
4. Add Lex bot alias data source and resoruce #8919

[roylines]

Great diligence @jzbruno! Thanks for this. Can't wait to see it get merged and released!

[nywilken]

And if that is the case can we get commitment to quick turn around? I am willing to commit more time to this but I don't want to get stuck waiting and with an unusable resource.

@jzbruno thanks for the quick turnaround with splitting this into multiple PRs. While I can't give an actual time commitment I can say that this PR along with the newly created PRs are being prioritized for the v2.16.0 release. I myself am new to the Lex service so I will need a little time to get up to speed here, but the other maintainers are available to assist as well so please don't be surprised if you see comments and suggestions from multiple maintainers.

I see you've called out the dependencies around testing for the new PRs. If there are any other edge cases or relevant information that comes to mind as we work through these PRs please feel free to add them as comments. Lastly, thanks for sticking with us and for pushing this contribution forward.

[jzbruno]

@nywilken Sounds good. Thanks for your help getting this reviewed.

[roylines]

Nearly there?

[jzbruno]

Getting close. We are working through the review on the first PR. The rest should go pretty quick once that is finished as I am updating the other PRs with the comments from the first as we go.

Those comments are happening here if you want to follow along / suggest anything. #8916

[bflad]

Since this pull request has been split into new ones (thank you!) (#2616 (comment)), closing this pull request as those should be followed instead.

• New Resource: aws_lex_slot_type Add Lex slot type data source and resource #8916
• New Resource: aws_lex_intent Add Lex intent data source and resource #8917
• New Resource: aws_lex_bot Add Lex bot data source and resoruce #8918
• New Resource: aws_lex_bot_alias Add Lex bot alias data source and resoruce #8919

For overall tracking of Lex support, please follow #905. Thanks. 😄

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!