Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken #default_tags-configuration-block reference in docs #26062

Merged

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Jul 31, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26059

Some references I encountered:

I've adjusted all of them to match: https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 31, 2022
@ewbankkit ewbankkit added documentation Introduces or discusses updates to documentation. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 1, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3223fdb into hashicorp:main Aug 1, 2022
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 1, 2022
ewbankkit added a commit to yktakaha4/terraform-provider-aws that referenced this pull request Aug 1, 2022
@bschaatsbergen bschaatsbergen deleted the e/fix-default-tags-provider-ref branch August 1, 2022 20:32
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link broken in documentation
2 participants