Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws guardduty organization configuration auto enable eks audit logs #25131 #25851

Merged
merged 11 commits into from
Jul 20, 2022
Merged

aws guardduty organization configuration auto enable eks audit logs #25131 #25851

merged 11 commits into from
Jul 20, 2022

Conversation

nickolivera
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25131

Enable Kubernetes Audit Logs Monitoring automatically for new member accounts.

Output from acceptance testing:

nick@nick1 terraform-provider-aws % TF_ACC=1 go test ./internal/service/guardduty -v -count 1 -parallel 1 -run='TestAccGuardDuty_serial' -timeout=180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/basic
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes
--- PASS: TestAccGuardDuty_serial (84.90s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (84.90s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/basic (38.75s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes (46.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  86.580s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 17, 2022
hashicorp#25131: website/docs/r/guardduty_organization_configuration.…
7116342 
…html.markdown:61:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
ewbankkit
ewbankkit approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGuardDuty_serial/OrganizationConfiguration' PKG=guardduty ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/guardduty/... -v -count 1 -parallel 2  -run=TestAccGuardDuty_serial/OrganizationConfiguration -timeout 180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/basic
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes
--- PASS: TestAccGuardDuty_serial (129.71s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (129.71s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/basic (45.08s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (33.08s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes (51.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	134.217s

@ewbankkit
Copy link
Contributor

@nickyamanaka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 11d8b4c into hashicorp:main Jul 20, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 20, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nickolivera nickolivera mentioned this pull request Jul 27, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

resource/aws_guardduty_organization_configuration: Add support for EKS Protection
2 participants
@nickolivera @ewbankkit