Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaff: Use names for errors, improve data source #25738

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

% make testacc TESTS="TestAccConfigService_serial/RemediationConfiguration" PKG=configservice 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/configservice/... -v -count 1 -parallel 20 -run='TestAccConfigService_serial/RemediationConfiguration'  -timeout 180m
--- PASS: TestAccConfigService_serial (836.11s)
    --- PASS: TestAccConfigService_serial/RemediationConfiguration (836.11s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basic (130.35s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/basicBackward (122.37s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/disappears (114.20s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/recreates (179.93s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/updates (166.07s)
        --- PASS: TestAccConfigService_serial/RemediationConfiguration/values (123.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	838.079s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/configservice Issues and PRs that pertain to the configservice service. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 7, 2022
@YakDriver YakDriver changed the title f skaff use names skaff: Use names for errors, improve data source Jul 7, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 7, 2022
@YakDriver YakDriver merged commit d1db813 into main Jul 7, 2022
@YakDriver YakDriver deleted the f-skaff-use-names branch July 7, 2022 22:23
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 7, 2022
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/configservice Issues and PRs that pertain to the configservice service. size/XL Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant