r/aws_kendra_faq

[GlennChia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13367

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendra_serial/Faq' PKG=kendra ACCTEST_TIMEOUT=220m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Faq -timeout 220m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Faq
=== RUN   TestAccKendra_serial/Faq/basic
=== RUN   TestAccKendra_serial/Faq/disappears
=== RUN   TestAccKendra_serial/Faq/tags
=== RUN   TestAccKendra_serial/Faq/Description
=== RUN   TestAccKendra_serial/Faq/FileFormat
=== RUN   TestAccKendra_serial/Faq/LanguageCode
--- PASS: TestAccKendra_serial (8921.17s)
    --- PASS: TestAccKendra_serial/Faq (8921.17s)
        --- PASS: TestAccKendra_serial/Faq/basic (1070.90s)
        --- PASS: TestAccKendra_serial/Faq/disappears (1880.72s)
        --- PASS: TestAccKendra_serial/Faq/tags (1782.86s)
        --- PASS: TestAccKendra_serial/Faq/Description (1004.78s)
        --- PASS: TestAccKendra_serial/Faq/FileFormat (1190.71s)
        --- PASS: TestAccKendra_serial/Faq/LanguageCode (1991.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     8921.285s

...

[anGie44]

Just one comment on the index_id validation, otherwise LGTM 🚀

Output of acceptance tests:

$ make testacc TESTARGS='-run=TestAccKendra_serial/Faq' PKG=kendra ACCTEST_TIMEOUT=2000m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 20  -run=TestAccKendra_serial/Faq -timeout 2000m
=== RUN   TestAccKendra_serial
=== RUN   TestAccKendra_serial/Faq
=== RUN   TestAccKendra_serial/Faq/basic
=== RUN   TestAccKendra_serial/Faq/disappears
=== RUN   TestAccKendra_serial/Faq/tags
=== RUN   TestAccKendra_serial/Faq/Description
=== RUN   TestAccKendra_serial/Faq/FileFormat
=== RUN   TestAccKendra_serial/Faq/LanguageCode
--- PASS: TestAccKendra_serial (9089.06s)
    --- PASS: TestAccKendra_serial/Faq (9089.06s)
        --- PASS: TestAccKendra_serial/Faq/basic (2006.85s)
        --- PASS: TestAccKendra_serial/Faq/disappears (1044.70s)
        --- PASS: TestAccKendra_serial/Faq/tags (2276.68s)
        --- PASS: TestAccKendra_serial/Faq/Description (1107.81s)
        --- PASS: TestAccKendra_serial/Faq/FileFormat (1097.96s)
        --- PASS: TestAccKendra_serial/Faq/LanguageCode (1555.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	9092.812s

[anGie44]

yeah i think as we move more steadily towards integrating AWS Go V2, we'll likely have a pattern for this documented

[anGie44]

Nice work @GlennChia , recent commits LGTM 🚀

[github-actions]

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.