Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_accessanayzer_archive_rule #25514

Merged
merged 12 commits into from
Jun 27, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jun 21, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11102

Output from acceptance testing:

Commercial

$ make testacc TESTS=TestAccAccessAnalyzer_serial PKG=accessanalyzer

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20 -run='TestAccAccessAnalyzer_serial'  -timeout 180m
=== RUN   TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Tags
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
    acctest.go:697: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/updateFilters
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/basic
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/disappears
--- PASS: TestAccAccessAnalyzer_serial (143.98s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (72.62s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (20.58s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (11.55s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/Tags (40.04s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (0.45s)
    --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (71.36s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (38.43s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (18.12s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (14.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	146.488s
...

Gov Cloud

$ make testacc TESTS=TestAccAccessAnalyzer_serial PKG=accessanalyzer

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/accessanalyzer/... -v -count 1 -parallel 20 -run='TestAccAccessAnalyzer_serial'  -timeout 180m
=== RUN   TestAccAccessAnalyzer_serial
=== RUN   TestAccAccessAnalyzer_serial/Analyzer
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Tags
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/Type_Organization
    acctest.go:697: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/basic
=== RUN   TestAccAccessAnalyzer_serial/Analyzer/disappears
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/basic
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/disappears
=== RUN   TestAccAccessAnalyzer_serial/ArchiveRule/update_filters
--- PASS: TestAccAccessAnalyzer_serial (135.27s)
    --- PASS: TestAccAccessAnalyzer_serial/Analyzer (67.51s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/Tags (39.91s)
        --- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (1.02s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (15.34s)
        --- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (11.24s)
    --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (67.76s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (15.86s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (14.16s)
        --- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (37.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	138.236s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 21, 2022
@johnsonaj johnsonaj changed the title F aws accessanayzer archive rule New Resource: aws_accessanayzer_archiverule Jun 21, 2022
@johnsonaj johnsonaj force-pushed the f-aws_accessanayzer_archive_rule branch from a169b27 to aaac158 Compare June 22, 2022 17:17
@johnsonaj johnsonaj marked this pull request as ready for review June 22, 2022 19:03
@johnsonaj johnsonaj changed the title New Resource: aws_accessanayzer_archiverule New Resource: aws_accessanayzer_archive_rule Jun 22, 2022
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. For completeness, we should have a test for adding, removing, and modifying filters

@johnsonaj johnsonaj requested a review from gdavison June 24, 2022 19:14
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccAccessAnalyzer_serial (165.46s)
--- PASS: TestAccAccessAnalyzer_serial/Analyzer (83.05s)
--- PASS: TestAccAccessAnalyzer_serial/Analyzer/basic (21.07s)
--- PASS: TestAccAccessAnalyzer_serial/Analyzer/disappears (14.44s)
--- PASS: TestAccAccessAnalyzer_serial/Analyzer/Tags (47.17s)
--- SKIP: TestAccAccessAnalyzer_serial/Analyzer/Type_Organization (0.36s)
--- PASS: TestAccAccessAnalyzer_serial/ArchiveRule (82.41s)
--- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/basic (20.91s)
--- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/disappears (17.40s)
--- PASS: TestAccAccessAnalyzer_serial/ArchiveRule/update_filters (44.11s)

@johnsonaj johnsonaj merged commit 0094d93 into main Jun 27, 2022
@johnsonaj johnsonaj deleted the f-aws_accessanayzer_archive_rule branch June 27, 2022 12:37
@github-actions github-actions bot added this to the v4.21.0 milestone Jun 27, 2022
github-actions bot pushed a commit that referenced this pull request Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS IAM Access Analyzer
2 participants