-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/cognito_user_pool_client - add enable_propagate_additional_user_context_data
argument + use finders
#25181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCognitoIDPUserPoolClient_' PKG=cognitoidp ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 2 -run=TestAccCognitoIDPUserPoolClient_ -timeout 180m
=== RUN TestAccCognitoIDPUserPoolClient_basic
=== PAUSE TestAccCognitoIDPUserPoolClient_basic
=== RUN TestAccCognitoIDPUserPoolClient_enableRevocation
=== PAUSE TestAccCognitoIDPUserPoolClient_enableRevocation
=== RUN TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_refreshTokenValidity
=== RUN TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_accessTokenValidity
=== RUN TestAccCognitoIDPUserPoolClient_idTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_idTokenValidity
=== RUN TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnits
=== RUN TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== PAUSE TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
=== RUN TestAccCognitoIDPUserPoolClient_name
=== PAUSE TestAccCognitoIDPUserPoolClient_name
=== RUN TestAccCognitoIDPUserPoolClient_allFields
=== PAUSE TestAccCognitoIDPUserPoolClient_allFields
=== RUN TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
=== RUN TestAccCognitoIDPUserPoolClient_analytics
=== PAUSE TestAccCognitoIDPUserPoolClient_analytics
=== RUN TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== PAUSE TestAccCognitoIDPUserPoolClient_analyticsWithARN
=== RUN TestAccCognitoIDPUserPoolClient_disappears
=== PAUSE TestAccCognitoIDPUserPoolClient_disappears
=== RUN TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== PAUSE TestAccCognitoIDPUserPoolClient_Disappears_userPool
=== CONT TestAccCognitoIDPUserPoolClient_basic
=== CONT TestAccCognitoIDPUserPoolClient_name
--- PASS: TestAccCognitoIDPUserPoolClient_basic (22.27s)
=== CONT TestAccCognitoIDPUserPoolClient_analyticsWithARN
--- PASS: TestAccCognitoIDPUserPoolClient_name (37.95s)
=== CONT TestAccCognitoIDPUserPoolClient_Disappears_userPool
--- PASS: TestAccCognitoIDPUserPoolClient_analyticsWithARN (24.61s)
=== CONT TestAccCognitoIDPUserPoolClient_disappears
--- PASS: TestAccCognitoIDPUserPoolClient_Disappears_userPool (15.15s)
=== CONT TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField
--- PASS: TestAccCognitoIDPUserPoolClient_disappears (16.40s)
=== CONT TestAccCognitoIDPUserPoolClient_analytics
--- PASS: TestAccCognitoIDPUserPoolClient_allFieldsUpdatingOneField (31.18s)
=== CONT TestAccCognitoIDPUserPoolClient_allFields
--- PASS: TestAccCognitoIDPUserPoolClient_allFields (19.10s)
=== CONT TestAccCognitoIDPUserPoolClient_idTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_analytics (48.52s)
=== CONT TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_idTokenValidity (33.00s)
=== CONT TestAccCognitoIDPUserPoolClient_tokenValidityUnits
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnitsWTokenValidity (36.12s)
=== CONT TestAccCognitoIDPUserPoolClient_enableRevocation
--- PASS: TestAccCognitoIDPUserPoolClient_tokenValidityUnits (33.64s)
=== CONT TestAccCognitoIDPUserPoolClient_accessTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_enableRevocation (42.97s)
=== CONT TestAccCognitoIDPUserPoolClient_refreshTokenValidity
--- PASS: TestAccCognitoIDPUserPoolClient_accessTokenValidity (30.86s)
--- PASS: TestAccCognitoIDPUserPoolClient_refreshTokenValidity (31.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 226.305s
This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: