r/aws_kendra_index #24920

GlennChia · 2022-05-22T09:05:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKendraIndex' PKG=kendra ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 5  -run=TestAccKendraIndex -timeout 180m
=== RUN   TestAccKendraIndex_basic
=== PAUSE TestAccKendraIndex_basic
=== RUN   TestAccKendraIndex_serverSideEncryption
=== PAUSE TestAccKendraIndex_serverSideEncryption
=== RUN   TestAccKendraIndex_updateCapacityUnits
=== PAUSE TestAccKendraIndex_updateCapacityUnits
=== RUN   TestAccKendraIndex_updateDescription
=== PAUSE TestAccKendraIndex_updateDescription
=== RUN   TestAccKendraIndex_updateName
=== PAUSE TestAccKendraIndex_updateName
=== RUN   TestAccKendraIndex_updateUserTokenJSON
=== PAUSE TestAccKendraIndex_updateUserTokenJSON
=== RUN   TestAccKendraIndex_updateTags
=== PAUSE TestAccKendraIndex_updateTags
=== RUN   TestAccKendraIndex_updateRoleARN
=== PAUSE TestAccKendraIndex_updateRoleARN
=== RUN   TestAccKendraIndex_disappears
=== PAUSE TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_basic
=== CONT  TestAccKendraIndex_updateUserTokenJSON
=== CONT  TestAccKendraIndex_updateRoleARN
=== CONT  TestAccKendraIndex_updateTags
=== CONT  TestAccKendraIndex_disappears
--- PASS: TestAccKendraIndex_basic (648.89s)
=== CONT  TestAccKendraIndex_updateDescription
--- PASS: TestAccKendraIndex_updateTags (1143.41s)
=== CONT  TestAccKendraIndex_updateName
--- PASS: TestAccKendraIndex_updateUserTokenJSON (1969.43s)
=== CONT  TestAccKendraIndex_updateCapacityUnits
--- PASS: TestAccKendraIndex_updateRoleARN (1970.17s)
=== CONT  TestAccKendraIndex_serverSideEncryption
--- PASS: TestAccKendraIndex_disappears (1980.02s)
--- PASS: TestAccKendraIndex_updateDescription (1646.30s)
--- PASS: TestAccKendraIndex_updateName (2116.22s)
--- PASS: TestAccKendraIndex_serverSideEncryption (1821.36s)
--- PASS: TestAccKendraIndex_updateCapacityUnits (4124.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     6094.482s

anGie44 · 2022-06-11T01:56:46Z

internal/service/kendra/index.go

+	// arn needed to update tags
+	arn := arn.ARN{
+		Partition: meta.(*conns.AWSClient).Partition,
+		Service:   "kendra",
+		Region:    meta.(*conns.AWSClient).Region,
+		AccountID: meta.(*conns.AWSClient).AccountID,
+		Resource:  fmt.Sprintf("index/%s", d.Id()),
+	}.String()
+
+	d.Set("arn", arn)
+
+	// waiter since the status changes from CREATING to either ACTIVE or FAILED
+	if _, err := waitIndexCreated(ctx, conn, d.Id(), d.Timeout(schema.TimeoutCreate)); err != nil {
+		return diag.Errorf("error waiting for Index (%s) creation: %s", d.Id(), err)
+	}
+
+	return resourceIndexUpdate(ctx, d, meta)
+}
+


since we won't need to update tags on create as they're passed directly in the CreateIndex method above, what if we only do an update when the capacity_units param is present as that is the only param we really need to do the update for at this stage e.g.

Suggested change

// arn needed to update tags

arn := arn.ARN{

Partition: meta.(*conns.AWSClient).Partition,

Service: "kendra",

Region: meta.(*conns.AWSClient).Region,

AccountID: meta.(*conns.AWSClient).AccountID,

Resource: fmt.Sprintf("index/%s", d.Id()),

}.String()

d.Set("arn", arn)

// waiter since the status changes from CREATING to either ACTIVE or FAILED

if _, err := waitIndexCreated(ctx, conn, d.Id(), d.Timeout(schema.TimeoutCreate)); err != nil {

return diag.Errorf("error waiting for Index (%s) creation: %s", d.Id(), err)

}

return resourceIndexUpdate(ctx, d, meta)

}

// waiter since the status changes from CREATING to either ACTIVE or FAILED

if _, err := waitIndexCreated(ctx, conn, d.Id(), d.Timeout(schema.TimeoutCreate)); err != nil {

return diag.Errorf("error waiting for Index (%s) creation: %s", d.Id(), err)

}

if v, ok := d.GetOk("capacity_units"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {

return resourceIndexUpdate(ctx, d, meta)

}

return resourceIndexRead(ctx, d, meta)

}

Oh there's also the document_metadata_configuration_updates that we have to update. Shall I move it up as well to group it with the capacity_units?

separate resource to handle this argument

Co-authored-by: Angie Pinilla <[email protected]>

GlennChia · 2022-06-14T05:33:20Z

Re-ran acceptance tests:

$ make testacc TESTARGS='-run=TestAccKendraIndex' PKG=kendra ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 5  -run=TestAccKendraIndex -timeout 180m
=== RUN   TestAccKendraIndex_basic
=== PAUSE TestAccKendraIndex_basic
=== RUN   TestAccKendraIndex_serverSideEncryption
=== PAUSE TestAccKendraIndex_serverSideEncryption
=== RUN   TestAccKendraIndex_updateCapacityUnits
=== PAUSE TestAccKendraIndex_updateCapacityUnits
=== RUN   TestAccKendraIndex_updateDescription
=== PAUSE TestAccKendraIndex_updateDescription
=== RUN   TestAccKendraIndex_updateName
=== PAUSE TestAccKendraIndex_updateName
=== RUN   TestAccKendraIndex_updateUserTokenJSON
=== PAUSE TestAccKendraIndex_updateUserTokenJSON
=== RUN   TestAccKendraIndex_updateTags
=== PAUSE TestAccKendraIndex_updateTags
=== RUN   TestAccKendraIndex_updateRoleARN
=== PAUSE TestAccKendraIndex_updateRoleARN
=== RUN   TestAccKendraIndex_disappears
=== PAUSE TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_basic
=== CONT  TestAccKendraIndex_updateUserTokenJSON
=== CONT  TestAccKendraIndex_updateRoleARN
=== CONT  TestAccKendraIndex_updateTags
=== CONT  TestAccKendraIndex_disappears
--- PASS: TestAccKendraIndex_basic (648.89s)
=== CONT  TestAccKendraIndex_updateDescription
--- PASS: TestAccKendraIndex_updateTags (1143.41s)
=== CONT  TestAccKendraIndex_updateName
--- PASS: TestAccKendraIndex_updateUserTokenJSON (1969.43s)
=== CONT  TestAccKendraIndex_updateCapacityUnits
--- PASS: TestAccKendraIndex_updateRoleARN (1970.17s)
=== CONT  TestAccKendraIndex_serverSideEncryption
--- PASS: TestAccKendraIndex_disappears (1980.02s)
--- PASS: TestAccKendraIndex_updateDescription (1646.30s)
--- PASS: TestAccKendraIndex_updateName (2116.22s)
--- PASS: TestAccKendraIndex_serverSideEncryption (1821.36s)
--- PASS: TestAccKendraIndex_updateCapacityUnits (4124.98s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kendra     6094.482s

anGie44 · 2022-06-14T16:29:25Z

Output of acceptance tests (commercial):

$ make testacc TESTARGS='-run=TestAccKendraIndex_' PKG=kendra ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 5  -run=TestAccKendraIndex_ -timeout 180m
=== RUN   TestAccKendraIndex_basic
=== PAUSE TestAccKendraIndex_basic
=== RUN   TestAccKendraIndex_serverSideEncryption
=== PAUSE TestAccKendraIndex_serverSideEncryption
=== RUN   TestAccKendraIndex_updateCapacityUnits
=== PAUSE TestAccKendraIndex_updateCapacityUnits
=== RUN   TestAccKendraIndex_updateDescription
=== PAUSE TestAccKendraIndex_updateDescription
=== RUN   TestAccKendraIndex_updateName
=== PAUSE TestAccKendraIndex_updateName
=== RUN   TestAccKendraIndex_updateUserTokenJSON
=== PAUSE TestAccKendraIndex_updateUserTokenJSON
=== RUN   TestAccKendraIndex_updateTags
=== PAUSE TestAccKendraIndex_updateTags
=== RUN   TestAccKendraIndex_updateRoleARN
=== PAUSE TestAccKendraIndex_updateRoleARN
=== RUN   TestAccKendraIndex_disappears
=== PAUSE TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_basic
=== CONT  TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_updateName
=== CONT  TestAccKendraIndex_updateRoleARN
=== CONT  TestAccKendraIndex_updateTags
--- PASS: TestAccKendraIndex_updateName (1215.67s)
=== CONT  TestAccKendraIndex_updateUserTokenJSON
--- PASS: TestAccKendraIndex_disappears (1226.29s)
=== CONT  TestAccKendraIndex_updateCapacityUnits
--- PASS: TestAccKendraIndex_basic (1605.74s)
=== CONT  TestAccKendraIndex_updateDescription
--- PASS: TestAccKendraIndex_updateRoleARN (1632.77s)
=== CONT  TestAccKendraIndex_serverSideEncryption
--- PASS: TestAccKendraIndex_updateTags (1660.11s)
--- PASS: TestAccKendraIndex_updateUserTokenJSON (980.96s)
--- PASS: TestAccKendraIndex_updateDescription (1637.03s)
--- PASS: TestAccKendraIndex_serverSideEncryption (1680.23s)
--- PASS: TestAccKendraIndex_updateCapacityUnits (3682.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	4913.792s

Output of acceptance tests (gov cloud):

$ make testacc TESTARGS='-run=TestAccKendraIndex_' PKG=kendra ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kendra/... -v -count 1 -parallel 5  -run=TestAccKendraIndex_ -timeout 180m
=== RUN   TestAccKendraIndex_basic
=== PAUSE TestAccKendraIndex_basic
=== RUN   TestAccKendraIndex_serverSideEncryption
=== PAUSE TestAccKendraIndex_serverSideEncryption
=== RUN   TestAccKendraIndex_updateCapacityUnits
=== PAUSE TestAccKendraIndex_updateCapacityUnits
=== RUN   TestAccKendraIndex_updateDescription
=== PAUSE TestAccKendraIndex_updateDescription
=== RUN   TestAccKendraIndex_updateName
=== PAUSE TestAccKendraIndex_updateName
=== RUN   TestAccKendraIndex_updateUserTokenJSON
=== PAUSE TestAccKendraIndex_updateUserTokenJSON
=== RUN   TestAccKendraIndex_updateTags
=== PAUSE TestAccKendraIndex_updateTags
=== RUN   TestAccKendraIndex_updateRoleARN
=== PAUSE TestAccKendraIndex_updateRoleARN
=== RUN   TestAccKendraIndex_disappears
=== PAUSE TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_basic
=== CONT  TestAccKendraIndex_updateUserTokenJSON
=== CONT  TestAccKendraIndex_disappears
=== CONT  TestAccKendraIndex_updateRoleARN
=== CONT  TestAccKendraIndex_updateDescription
--- PASS: TestAccKendraIndex_updateRoleARN (1005.28s)
=== CONT  TestAccKendraIndex_updateName
--- PASS: TestAccKendraIndex_updateDescription (1128.96s)
=== CONT  TestAccKendraIndex_updateCapacityUnits
--- PASS: TestAccKendraIndex_basic (2328.40s)
=== CONT  TestAccKendraIndex_serverSideEncryption
--- PASS: TestAccKendraIndex_updateUserTokenJSON (2332.72s)
=== CONT  TestAccKendraIndex_updateTags
--- PASS: TestAccKendraIndex_disappears (2387.11s)
--- PASS: TestAccKendraIndex_updateName (2359.16s)
--- PASS: TestAccKendraIndex_updateTags (1341.43s)
--- PASS: TestAccKendraIndex_serverSideEncryption (1735.79s)
--- PASS: TestAccKendraIndex_updateCapacityUnits (3988.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kendra	5120.875s

github-actions · 2022-06-17T01:20:35Z

This functionality has been released in v4.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-07-20T02:37:36Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

GlennChia added 18 commits May 22, 2022 05:29

feat(kendra): generate tags

71964df

feat(kendra): index schema

0f09864

feat(kendra): index read

6cee0a0

feat(kendra): index create

61d83a4

feat(kendra): index update

135d04c

feat(kendra): index delete

867cf3d

feat(kendra): waiter for index create

d37edef

feat(kendra): waiter for index update

6cfcc5e

feat(kendra): waiter for index delete

582772d

fix(kendra): rm MaxItems from computed field

13881d4

fix(kendra): change computed req to computed opt

4d0d356

feat(kendra): add aws_kendra_index

a9dad29

test(kendra): index exists

4232e1f

test(kendra): index destroy

32277b6

test(kendra): index disappears

33a356c

test(kendra): add sleep for index to find iam role

a1115c5

fix(kendra): increase delete timeouts

44905df

docs(kendra): aws_kendra_index

250dcbd

GlennChia added 3 commits May 22, 2022 11:55

fix(kendra): DiffSuppress default edition

33d8375

fix(kendra): DiffSuppress default user_context_pol

226aae8

test(kendra): index basic

a12d65e

GlennChia added 2 commits June 9, 2022 03:48

docs(kendra): rm unused header

38b0d99

Merge branch 'main' into f-aws_kendra_index

e036f53

GlennChia force-pushed the f-aws_kendra_index branch from 4b05209 to e036f53 Compare June 9, 2022 03:49

GlennChia added 4 commits June 10, 2022 05:14

feat(kendra): add capacity units argument

fe8f644

chore(kendra): shift kendra package to top req blk

984a829

chore(kendra): add MaxItems to capacity_units

ec6f345

feat(kendra): add doc metadata config updates

7b909d2

github-actions bot added the flex Pertains to FLatteners and EXpanders. label Jun 10, 2022

GlennChia force-pushed the f-aws_kendra_index branch from 6559997 to e9428ee Compare June 10, 2022 15:21

style(kendra): terrafmt

abbef4a

GlennChia force-pushed the f-aws_kendra_index branch from e9428ee to abbef4a Compare June 10, 2022 15:22

anGie44 reviewed Jun 11, 2022

View reviewed changes

GlennChia added 2 commits June 13, 2022 16:18

refactor(kendra): mv cap_units update to create

2b80234

refactor(kendra): rm doc_meta_config from update

726dca0

separate resource to handle this argument

github-actions bot removed the flex Pertains to FLatteners and EXpanders. label Jun 13, 2022

GlennChia added 2 commits June 13, 2022 16:53

refactor(kendra): rm arn set for capacity_units

f87e994

fix(kendra): add capacity_units to update

17c2425

anGie44 mentioned this pull request Jun 14, 2022

r/kendra_experience: new resource #25315

Merged

refactor(kendra): retry logic to wait for iam role

0514a5d

Co-authored-by: Angie Pinilla <[email protected]>

anGie44 modified the milestones: Roadmap, v4.19.0 Jun 14, 2022

add small detail in docs

0ad3618

anGie44 merged commit d8ad188 into hashicorp:main Jun 14, 2022

GlennChia deleted the f-aws_kendra_index branch June 19, 2022 12:38

github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_kendra_index #24920

r/aws_kendra_index #24920

GlennChia commented May 22, 2022 •

edited

Loading

anGie44 Jun 11, 2022 •

edited

Loading

GlennChia Jun 11, 2022

GlennChia commented Jun 14, 2022

anGie44 commented Jun 14, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jul 20, 2022

r/aws_kendra_index #24920

r/aws_kendra_index #24920

Conversation

GlennChia commented May 22, 2022 • edited Loading

Community Note

anGie44 Jun 11, 2022 • edited Loading

Choose a reason for hiding this comment

GlennChia Jun 11, 2022

Choose a reason for hiding this comment

GlennChia commented Jun 14, 2022

anGie44 commented Jun 14, 2022

github-actions bot commented Jun 17, 2022

github-actions bot commented Jul 20, 2022

GlennChia commented May 22, 2022 •

edited

Loading

anGie44 Jun 11, 2022 •

edited

Loading