-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/redshift_event_subscription - use finder + validations #24909
r/redshift_event_subscription - use finder + validations #24909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftEventSubscription_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2 -run=TestAccRedshiftEventSubscription_ -timeout 180m
=== RUN TestAccRedshiftEventSubscription_basic
=== PAUSE TestAccRedshiftEventSubscription_basic
=== RUN TestAccRedshiftEventSubscription_withSourceIDs
=== PAUSE TestAccRedshiftEventSubscription_withSourceIDs
=== RUN TestAccRedshiftEventSubscription_categoryUpdate
=== PAUSE TestAccRedshiftEventSubscription_categoryUpdate
=== RUN TestAccRedshiftEventSubscription_tags
=== PAUSE TestAccRedshiftEventSubscription_tags
=== RUN TestAccRedshiftEventSubscription_disappears
=== PAUSE TestAccRedshiftEventSubscription_disappears
=== CONT TestAccRedshiftEventSubscription_basic
=== CONT TestAccRedshiftEventSubscription_tags
--- PASS: TestAccRedshiftEventSubscription_basic (42.31s)
=== CONT TestAccRedshiftEventSubscription_categoryUpdate
--- PASS: TestAccRedshiftEventSubscription_tags (58.49s)
=== CONT TestAccRedshiftEventSubscription_withSourceIDs
--- PASS: TestAccRedshiftEventSubscription_categoryUpdate (39.08s)
=== CONT TestAccRedshiftEventSubscription_disappears
--- PASS: TestAccRedshiftEventSubscription_withSourceIDs (37.32s)
--- PASS: TestAccRedshiftEventSubscription_disappears (19.48s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshift 107.931s
@DrFaust92 Thanks for the contribution 🎉 👏. |
% make providerlint && make golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing: