-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabled_metrics to aws_autoscaling_group data source #24691
Conversation
* Add enalbed_metrics to schema and read function * Add checks to existing acc tests * Add bullet line in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ed-brex 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAutoScalingGroupDataSource_ PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run='TestAccAutoScalingGroupDataSource_' -timeout 180m
=== RUN TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== CONT TestAccAutoScalingGroupDataSource_basic
=== CONT TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (60.37s)
--- PASS: TestAccAutoScalingGroupDataSource_basic (63.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 66.851s
@ed-brex Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing:
👋 This is my first contribution to this provider. These changes are largely cargo-culted from existing values.
Tried my best to follow the guidelines from Enhancement/Bugfix to a Resource & Basic Acceptance Tests.
More than happy to make any changes/fixes to make things up-to-snuff.