acctest/aws_iot_topic_rule_destination: Better resource deletion

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #24395.

In nightly CI:

=== RUN   TestAccIoTTopicRuleDestination_enabled
=== PAUSE TestAccIoTTopicRuleDestination_enabled
=== CONT  TestAccIoTTopicRuleDestination_enabled
topic_rule_destination_test.go:77: Step 1/4 error: Error running apply: exit status 1
Error: waiting for IoT Topic Rule Destination (arn:aws:iot:us-west-2:187416307283:ruledestination/vpc/b8412e43-8a06-436e-b70d-6bea4c1b2e83) disable: unexpected state 'IN_PROGRESS', wanted target 'DISABLED'. last error: Disabling VPC destination
with aws_iot_topic_rule_destination.test,
on terraform_plugin_test.tf line 74, in resource "aws_iot_topic_rule_destination" "test":
74: resource "aws_iot_topic_rule_destination" "test" {
testing_new.go:79: Error running post-test destroy, there may be dangling resources: exit status 1
Error: deleting IoT Topic Rule Destination: InvalidRequestException: Cannot delete destination: arn:aws:iot:us-west-2:187416307283:ruledestination/vpc/b8412e43-8a06-436e-b70d-6bea4c1b2e83 with status: IN_PROGRESS
--- FAIL: TestAccIoTTopicRuleDestination_enabled (517.51s)
=== RUN   TestAccIoTTopicRuleDestination_basic
=== PAUSE TestAccIoTTopicRuleDestination_basic
=== CONT  TestAccIoTTopicRuleDestination_basic
testing_new.go:79: Error running post-test destroy, there may be dangling resources: exit status 1
Error: error deleting EC2 Subnet (subnet-03a2407e1e78bde13): DependencyViolation: The subnet 'subnet-03a2407e1e78bde13' has dependencies and cannot be deleted.
  status code: 400, request id: e92baf33-5515-481a-85c7-4caf2a70eae1
Error: error deleting EC2 Subnet (subnet-0af84ab86a4c973de): DependencyViolation: The subnet 'subnet-0af84ab86a4c973de' has dependencies and cannot be deleted.
  status code: 400, request id: eb6d3e8e-a62e-4ad5-90aa-6468ee0c2392
Error: Error deleting security group: DependencyViolation: resource sg-01a7ee67494760868 has a dependent object
  status code: 400, request id: 03151e7b-f880-4e9e-a91c-08eeb7bf16ab
--- FAIL: TestAccIoTTopicRuleDestination_basic (2000.31s)

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccIoTTopicRuleDestination_enabled PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTTopicRuleDestination_enabled'  -timeout 180m
=== RUN   TestAccIoTTopicRuleDestination_enabled
=== PAUSE TestAccIoTTopicRuleDestination_enabled
=== CONT  TestAccIoTTopicRuleDestination_enabled
--- PASS: TestAccIoTTopicRuleDestination_enabled (1772.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	1779.257s
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTS=TestAccIoTTopicRule_kafka PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTTopicRule_kafka'  -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.44.8
=== RUN   TestAccIoTTopicRule_kafka
=== PAUSE TestAccIoTTopicRule_kafka
=== CONT  TestAccIoTTopicRule_kafka
--- PASS: TestAccIoTTopicRule_kafka (846.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	850.589s

[github-actions]

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.