Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_route: Call SetId before WaitRouteReady #24024

Merged
merged 13 commits into from
Apr 5, 2022
Merged

r/aws_route: Call SetId before WaitRouteReady #24024

merged 13 commits into from
Apr 5, 2022

Commits on Apr 4, 2022

  1. resource/aws_route: SetId before WaitRouteReady 

    When the route's wait-for-creation operation times out,
its state is leaked as `d.SetId(...)` is called after the
`WaitRouteReady(...)`. So, the next time the configuration
is applied, the Terraform engine tries to create the same
route again, getting duplication error from AWS.

Call `d.SetId(...)` before `WaitRouteReady(...)`.

Fixes: hashicorp#23827
    @gmichelo
    gmichelo committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3776f51 View commit details
    Browse the repository at this point in the history

  2. resource/aws_route: SetId before WaitRouteReady 

    Issue:
When the route's wait-for-creation operation times out,
its state is leaked as `d.SetId(...)` is called after the
`WaitRouteReady(...)`. So, the next time the configuration
is applied, the Terraform engine tries to create the same
route again, getting duplication error from AWS.

Fix:
Call `d.SetId(...)` before `WaitRouteReady(...)`.

Fixes: hashicorp#23827
    @gmichelo
    gmichelo committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b49ba82 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue-23827' of github.com:bigmikes/terraform-provider-… 

    …aws into issue-23827
    @gmichelo
    gmichelo committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    3bfba0a View commit details
    Browse the repository at this point in the history

  4. Changelog file

    @gmichelo
    gmichelo committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e8eca40 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Tweak CHANGELOG entry.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    fb702cd View commit details
    Browse the repository at this point in the history

  2. r/aws_route: Add 'core_network_arn' argument.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    bda73c9 View commit details
    Browse the repository at this point in the history

  3. d/aws_route: Add 'core_network_arn' argument.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2fe6dfd View commit details
    Browse the repository at this point in the history

  4. r/aws_route_table: Add 'core_network_arn' argument to 'route' configu… 

    …ration block.
    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d163536 View commit details
    Browse the repository at this point in the history

  5. d/aws_route_table: Add 'routes.core_network_arn' attribute.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    787e162 View commit details
    Browse the repository at this point in the history

  6. r/aws_default_route_table: Add 'core_network_arn' argument to 'route'… 

    … configuration block.
    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9411929 View commit details
    Browse the repository at this point in the history

  7. r/aws_vpn_connection: Add 'core_network_arn' and 'core_network_attach… 

    …ment_arn' attributes.
    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    56710c9 View commit details
    Browse the repository at this point in the history

  8. Fix typo.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b1f6280 View commit details
    Browse the repository at this point in the history

  9. Fix typo.

    @ewbankkit
    ewbankkit committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a45997c View commit details
    Browse the repository at this point in the history