Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamo_contributor_insights: Add new resource #23947

Merged
merged 13 commits into from
Apr 4, 2022

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13933

Description

Creates new resource for aws_dynamodb_contributor_insights

resource "aws_dynamodb_contributor_insights" "test" {
  table_name = "TestTableName"
}

Output from acceptance testing:

$ make testacc TESTS=TestAccContributorInsights_ PKG=dynamodb

=== RUN   TestAccContributorInsights_basic
=== PAUSE TestAccContributorInsights_basic
=== RUN   TestAccContributorInsights_disappears
=== PAUSE TestAccContributorInsights_disappears
=== CONT  TestAccContributorInsights_basic
=== CONT  TestAccContributorInsights_disappears
--- PASS: TestAccContributorInsights_disappears (32.56s)
--- PASS: TestAccContributorInsights_basic (56.66s)
PASS
...

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Mar 30, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 30, 2022
@johnsonaj johnsonaj force-pushed the r/aws_dynamo_contributor_insights branch from 3017626 to b01c898 Compare March 30, 2022 20:53
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Mar 31, 2022
@johnsonaj johnsonaj marked this pull request as ready for review April 1, 2022 13:42
@ewbankkit
Copy link
Contributor

AWS Commercial
% make testacc TESTS=TestAccContributorInsights_ PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccContributorInsights_'  -timeout 180m
=== RUN   TestAccContributorInsights_basic
=== PAUSE TestAccContributorInsights_basic
=== CONT  TestAccContributorInsights_basic
--- PASS: TestAccContributorInsights_basic (86.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	89.966s
AWS GovCloud
% make testacc TESTS=TestAccContributorInsights_ PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccContributorInsights_'  -timeout 180m
=== RUN   TestAccContributorInsights_basic
=== PAUSE TestAccContributorInsights_basic
=== CONT  TestAccContributorInsights_basic
--- PASS: TestAccContributorInsights_basic (77.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	80.791s

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccContributorInsights_ PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccContributorInsights_'  -timeout 180m
=== RUN   TestAccContributorInsights_basic
=== PAUSE TestAccContributorInsights_basic
=== RUN   TestAccContributorInsights_disappears
=== PAUSE TestAccContributorInsights_disappears
=== CONT  TestAccContributorInsights_basic
=== CONT  TestAccContributorInsights_disappears
--- PASS: TestAccContributorInsights_disappears (36.85s)
--- PASS: TestAccContributorInsights_basic (52.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	56.407s

@johnsonaj johnsonaj merged commit 5aad897 into main Apr 4, 2022
@johnsonaj johnsonaj deleted the r/aws_dynamo_contributor_insights branch April 4, 2022 21:31
@github-actions github-actions bot added this to the v4.9.0 milestone Apr 4, 2022
github-actions bot pushed a commit that referenced this pull request Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: DynamoDB CloudWatch Contributor Insights
2 participants