Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_keyspaces_keyspace #23770

Merged
merged 6 commits into from
Mar 21, 2022

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11221

Output from acceptance testing:

$ make testacc PKG=keyspaces TESTS=TestAccKeyspacesKeyspace_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 20 -run='TestAccKeyspacesKeyspace_'  -timeout 180m
=== RUN   TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN   TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN   TestAccKeyspacesKeyspace_update_tags
=== PAUSE TestAccKeyspacesKeyspace_update_tags
=== CONT  TestAccKeyspacesKeyspace_basic
=== CONT  TestAccKeyspacesKeyspace_update_tags
=== CONT  TestAccKeyspacesKeyspace_disappears
--- PASS: TestAccKeyspacesKeyspace_disappears (53.40s)
--- PASS: TestAccKeyspacesKeyspace_basic (55.76s)
--- PASS: TestAccKeyspacesKeyspace_update_tags (76.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces  78.486s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/keyspaces Issues and PRs that pertain to the keyspaces service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 20, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG=keyspaces TESTS=TestAccKeyspacesKeyspace_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run='TestAccKeyspacesKeyspace_'  -timeout 180m
=== RUN   TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN   TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN   TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== CONT  TestAccKeyspacesKeyspace_basic
=== CONT  TestAccKeyspacesKeyspace_tags
--- PASS: TestAccKeyspacesKeyspace_basic (67.18s)
=== CONT  TestAccKeyspacesKeyspace_disappears
--- PASS: TestAccKeyspacesKeyspace_tags (91.21s)
--- PASS: TestAccKeyspacesKeyspace_disappears (60.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	132.009s
GovCloud
% make testacc PKG=keyspaces TESTS=TestAccKeyspacesKeyspace_ ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/keyspaces/... -v -count 1 -parallel 2 -run='TestAccKeyspacesKeyspace_'  -timeout 180m
=== RUN   TestAccKeyspacesKeyspace_basic
=== PAUSE TestAccKeyspacesKeyspace_basic
=== RUN   TestAccKeyspacesKeyspace_disappears
=== PAUSE TestAccKeyspacesKeyspace_disappears
=== RUN   TestAccKeyspacesKeyspace_tags
=== PAUSE TestAccKeyspacesKeyspace_tags
=== CONT  TestAccKeyspacesKeyspace_basic
=== CONT  TestAccKeyspacesKeyspace_tags
=== CONT  TestAccKeyspacesKeyspace_basic
    keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
--- SKIP: TestAccKeyspacesKeyspace_basic (1.00s)
=== CONT  TestAccKeyspacesKeyspace_tags
    keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
=== CONT  TestAccKeyspacesKeyspace_disappears
--- SKIP: TestAccKeyspacesKeyspace_tags (1.00s)
=== CONT  TestAccKeyspacesKeyspace_disappears
    keyspace_test.go:24: Keyspaces is not supported in aws-us-gov partition
--- SKIP: TestAccKeyspacesKeyspace_disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	4.506s
Sweeper
% make sweep SWEEPARGS=-sweep-run=aws_keyspaces_keyspace SWEEP=us-west-2
...
2022/03/21 09:24:46 [DEBUG] Completed Sweeper (aws_keyspaces_keyspace) in region (us-west-2) in 1.67538533s
2022/03/21 09:24:46 Completed Sweepers for region (us-west-2) in 1.675526652s
2022/03/21 09:24:46 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_keyspaces_keyspace
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	6.952s

@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 21, 2022

@roberth-k Thanks for the contribution 🎉 👏.
I made a couple of minor cosmetic changes:

@ewbankkit ewbankkit merged commit 5acbfc0 into hashicorp:main Mar 21, 2022
@github-actions github-actions bot added this to the v4.7.0 milestone Mar 21, 2022
@github-actions
Copy link

This functionality has been released in v4.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/keyspaces Issues and PRs that pertain to the keyspaces service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants