Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource: aws_db_instance_automated_backups_replication #23759

Merged
merged 33 commits into from
Mar 29, 2022
Merged

New resource: aws_db_instance_automated_backups_replication #23759

merged 33 commits into from
Mar 29, 2022

Commits on Aug 5, 2021

  1. feat: add aws_db_instance_automated_backups_replication 

    Signed-off-by: marcin.janas <[email protected]>
    @marcin-janas
    marcin-janas committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    955b974 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. db_instance_backup_replication - WIP on new resource

    @bschaatsbergen
    bschaatsbergen committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b2e5468 View commit details
    Browse the repository at this point in the history

  2. db_instance_backup_replication - more wip on the new resource

    @bschaatsbergen
    bschaatsbergen committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    6827e79 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. db_instance_backup_replication - remove destination_region, as 'reg… 

    …ion' is set through either env var or provider. And give a default value for `retention_period`
    @bschaatsbergen
    bschaatsbergen committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    43e9e42 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. db_instance_backup_replication - add a waiter

    @bschaatsbergen
    bschaatsbergen committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    fca6fc0 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Touch up deletion flow, wait for source database to be available

    @bschaatsbergen
    bschaatsbergen committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    1c9d0c2 View commit details
    Browse the repository at this point in the history

  2. Add db_instance_backup_replication tests

    @bschaatsbergen
    bschaatsbergen committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    23fe794 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Add retention_period and KMS encrypted backup acceptance test

    @bschaatsbergen
    bschaatsbergen committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    2c2c7f8 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Rename to aws_db_instance_automated_backup_replication

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    a6f13f7 View commit details
    Browse the repository at this point in the history

  2. terrafmt testAccInstanceAutomatedBackupReplicationConfig_kmsEncrypted

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    bbb84a4 View commit details
    Browse the repository at this point in the history

  3. Create CHANGELOG entry

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    411d4e7 View commit details
    Browse the repository at this point in the history

  4. Update db_instance_automated_backup_replication.markdown

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    0dc91aa View commit details
    Browse the repository at this point in the history

  5. Surround fenced code blocks with blank links and fix typo

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    ede999b View commit details
    Browse the repository at this point in the history

  6. Remove tab

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    b27db95 View commit details
    Browse the repository at this point in the history

  7. Update db_instance_automated_backup_replication.markdown

    @bschaatsbergen
    bschaatsbergen authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    c7d9fff View commit details
    Browse the repository at this point in the history

  8. Revert "Update db_instance_automated_backup_replication.markdown" 

    This reverts commit c7d9fff.
    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    6b7cea2 View commit details
    Browse the repository at this point in the history

  9. Move retained status check to `resourceInstanceAutomatedBackupReplica… 

    …tionRead` op
    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    1506c50 View commit details
    Browse the repository at this point in the history

  10. Remove NotFound check in delete op, this is already handled in the read

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    2dc70db View commit details
    Browse the repository at this point in the history

  11. Update instance_automated_backup_replication_test.go

    @bschaatsbergen
    bschaatsbergen committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    de608b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Fix acceptance tests, iterate through CheckDestroy response

    @bschaatsbergen
    bschaatsbergen committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c990f49 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Removed unused const dbInstanceAutomatedBackupReplicationRetained

    @bschaatsbergen
    bschaatsbergen committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    8ade2a2 View commit details
    Browse the repository at this point in the history

  2. r/aws_db_instance_automated_backup_replication: Alphabetize attributes.

    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    e4ff8de View commit details
    Browse the repository at this point in the history

  3. r/aws_db_instance_automated_backup_replication: No need to document a… 

    …ttributes that are arguments.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    d938b63 View commit details
    Browse the repository at this point in the history

  4. r/aws_db_instance_automated_backup_replication: 'waitDBInstanceAutoma… 

    …tedBackupAvailable' returns 'rds.DBInstanceAutomatedBackup'.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    050331d View commit details
    Browse the repository at this point in the history

  5. r/aws_db_instance_automated_backup_replication: 'FindDBInstanceAutoma… 

    …tedBackupByID' -> 'FindDBInstanceAutomatedBackupByARN'.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    7b4046f View commit details
    Browse the repository at this point in the history

  6. r/aws_db_instance_automated_backup_replication: Use 'FindDBInstanceAu… 

    …tomatedBackupByARN'.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    392d369 View commit details
    Browse the repository at this point in the history

  7. Derive source DB region from its ARN.

    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    b4f4967 View commit details
    Browse the repository at this point in the history

  8. r/aws_db_instance_automated_backup_replication: Change the logic for … 

    …waiting for deletion.

Acceptance test output:

% make testacc TESTS=TestAccRDSInstanceAutomatedBackupReplication_basic PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceAutomatedBackupReplication_basic'  -timeout 180m
=== RUN   TestAccRDSInstanceAutomatedBackupReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupReplication_basic
=== CONT  TestAccRDSInstanceAutomatedBackupReplication_basic
--- PASS: TestAccRDSInstanceAutomatedBackupReplication_basic (1340.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1345.529s
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    c6ad6a7 View commit details
    Browse the repository at this point in the history

  9. Revert "feat: add aws_db_instance_automated_backups_replication" 

    This reverts commit 955b974.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    3e533da View commit details
    Browse the repository at this point in the history

  10. Merge commit '3e533dadf2685fd50ae3c5cee62918d1e86a866c' into HEAD

    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    12a87eb View commit details
    Browse the repository at this point in the history

  11. r/aws_db_instance_automated_backup_replication: Add 'pre_signed_url' … 

    …argument.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    38de16e View commit details
    Browse the repository at this point in the history

  12. 'aws_db_instance_automated_backup_replication' -> 'aws_db_instance_au… 

    …tomated_backups_replication'; Rename files.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    2b33840 View commit details
    Browse the repository at this point in the history

  13. 'aws_db_instance_automated_backup_replication' -> 'aws_db_instance_au… 

    …tomated_backups_replication'; Rename functions.
    @ewbankkit
    ewbankkit committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    9ced21c View commit details
    Browse the repository at this point in the history