r/aws_quicksight_user: allow custom namespaces

[taharah]

Signed-off-by: Trevor Wood [email protected]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21166

Output from acceptance testing:

make testacc TESTS=TestAccQuickSightUser_ PKG=quicksight
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightUser_'  -timeout 180m
=== RUN   TestAccQuickSightUser_basic
=== PAUSE TestAccQuickSightUser_basic
=== RUN   TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
=== PAUSE TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
=== RUN   TestAccQuickSightUser_withNamespace
=== PAUSE TestAccQuickSightUser_withNamespace
=== RUN   TestAccQuickSightUser_disappears
=== PAUSE TestAccQuickSightUser_disappears
=== CONT  TestAccQuickSightUser_basic
=== CONT  TestAccQuickSightUser_disappears
=== CONT  TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
=== CONT  TestAccQuickSightUser_withNamespace
--- PASS: TestAccQuickSightUser_disappears (17.41s)
--- PASS: TestAccQuickSightUser_withNamespace (18.65s)
--- PASS: TestAccQuickSightUser_basic (31.54s)
--- PASS: TestAccQuickSightUser_withInvalidFormattedEmailStillWorks (32.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 34.220s

Maintainer Notes:

Quicksight testing is dependent on the manual turning on/creation of an Enterprise Quicksight subscription and a Quicksight namespace with the name "terraform". If running the tests, ensure to enable an Enterprise Quicksight subscription, create a namespace named "terraform", and set region appropriately before.

[github-actions]

Welcome @taharah 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccQuickSightUser_ PKG=quicksight ACCTEST_PARALLELISM=2                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 2 -run='TestAccQuickSightUser_'  -timeout 180m
=== RUN   TestAccQuickSightUser_basic
=== PAUSE TestAccQuickSightUser_basic
=== RUN   TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
=== PAUSE TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
=== RUN   TestAccQuickSightUser_withNamespace
    user_test.go:87: Environment variable QUICKSIGHT_NAMESPACE is not set
--- SKIP: TestAccQuickSightUser_withNamespace (0.00s)
=== RUN   TestAccQuickSightUser_disappears
=== PAUSE TestAccQuickSightUser_disappears
=== CONT  TestAccQuickSightUser_basic
=== CONT  TestAccQuickSightUser_disappears
--- PASS: TestAccQuickSightUser_disappears (14.90s)
=== CONT  TestAccQuickSightUser_withInvalidFormattedEmailStillWorks
--- PASS: TestAccQuickSightUser_basic (29.92s)
--- PASS: TestAccQuickSightUser_withInvalidFormattedEmailStillWorks (28.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	48.708s

[ewbankkit]

@taharah Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.