-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cutom vpc for app runner #23173
Add cutom vpc for app runner #23173
Conversation
Co-authored-by: Synohara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccAppRunnerVpcConnector_ PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVpcConnector_' -timeout 180m
=== RUN TestAccAppRunnerVpcConnector_basic
=== PAUSE TestAccAppRunnerVpcConnector_basic
=== RUN TestAccAppRunnerVpcConnector_disappears
=== PAUSE TestAccAppRunnerVpcConnector_disappears
=== RUN TestAccAppRunnerVpcConnector_tags
=== PAUSE TestAccAppRunnerVpcConnector_tags
=== CONT TestAccAppRunnerVpcConnector_basic
=== CONT TestAccAppRunnerVpcConnector_tags
=== CONT TestAccAppRunnerVpcConnector_disappears
--- PASS: TestAccAppRunnerVpcConnector_disappears (46.70s)
--- PASS: TestAccAppRunnerVpcConnector_tags (51.90s)
--- PASS: TestAccAppRunnerVpcConnector_basic (52.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 56.765s
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_basic\|TestAccAppRunnerService_ImageRepository_networkConfiguration' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run=TestAccAppRunnerService_ImageRepository_basic\|TestAccAppRunnerService_ImageRepository_networkConfiguration -timeout 180m
=== RUN TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT TestAccAppRunnerService_ImageRepository_basic
=== CONT TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_basic (272.17s)
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (507.69s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/apprunner 511.538s
@Yoshiitaka Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23090
Output from acceptance testing: