Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Adds parameters for multiple config and credentials files #23080

Merged
merged 3 commits into from
Feb 10, 2022
Merged

provider: Adds parameters for multiple config and credentials files #23080

merged 3 commits into from
Feb 10, 2022
+64 −24

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 9, 2022

The AWS SDK for Go v2 allows passing multiple shared credentials and shared config files. Note that the corresponding environment variables, AWS_SHARED_CREDENTIALS_FILE and AWS_CONFIG_FILE accept single files only.

  1. Document support for both environment variables
  2. Add parameter shared_credentials_files
  3. Add parameter shared_config_files
  4. Deprecate shared_credentials_file

Closes #23027

Output from acceptance testing:

N/A

@gdavison gdavison added this to the v4.0.0 milestone Feb 9, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 9, 2022
anGie44
anGie44 reviewed Feb 9, 2022
View reviewed changes
internal/provider/provider.go
@@ -315,18 +315,26 @@ func Provider() *schema.Provider {
Description: "The secret key for API operations. You can retrieve this\n" +
"from the 'Security & Credentials' section of the AWS console.",
},
"shared_config_file": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we consider deprecating this field first before full removal for consistency?

Copy link
Contributor

@anGie44 anGie44 Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahaha ignore me..all good . didn't see this was added just recently in the milestone 🤦‍♀️

anGie44
anGie44 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

@gdavison gdavison merged commit 47008dc into main Feb 10, 2022
@gdavison gdavison deleted the multiple-config branch February 10, 2022 01:30
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
Update CHANGELOG.md for #23080
60bd245
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

provider: Add multiple credentials and config files parameters
2 participants
@gdavison @anGie44