Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval #22222

Merged

Conversation

sjonpaulbrown
Copy link

@sjonpaulbrown sjonpaulbrown commented Dec 15, 2021

This pull request adds the ability to recursively retrieve ssm parameters under the provided path. The recursive argument has been added to the aws_ssm_parameters_by_path data source. The argument remains optional and defaults to false if not provided.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21896

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccSSMParametersByPathDataSource_' PKG_NAME=internal/service/ssm
make testacc TESTARGS='-run=TestAccSSMParametersByPathDataSource_' PKG_NAME=internal/service/ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run=TestAccSSMParametersByPathDataSource_ -timeout 180m
=== RUN   TestAccSSMParametersByPathDataSource_basic
=== PAUSE TestAccSSMParametersByPathDataSource_basic
=== RUN   TestAccSSMParametersByPathDataSource_withRecursion
=== PAUSE TestAccSSMParametersByPathDataSource_withRecursion
=== CONT  TestAccSSMParametersByPathDataSource_basic
=== CONT  TestAccSSMParametersByPathDataSource_withRecursion
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (31.70s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (31.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        45.079s

Example Usage

data "aws_ssm_parameters_by_path" "params" {
  path = "/my/fake/path/"
  recursive = true
}

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssm Issues and PRs that pertain to the ssm service. needs-triage Waiting for first response or review from a maintainer. labels Dec 15, 2021
@sjonpaulbrown sjonpaulbrown force-pushed the f-aws_ssm_parameters_by_path-recursion branch from 11db115 to 7005a1d Compare December 15, 2021 03:26
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 15, 2021
@sjonpaulbrown sjonpaulbrown changed the title [WIP] f/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval f/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval Dec 15, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @sjonpaulbrown 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@sjonpaulbrown sjonpaulbrown changed the title f/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval b/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval Dec 15, 2021
@sjonpaulbrown sjonpaulbrown changed the title b/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval f/aws_ssm_parameters_by_path: Add support for recursive parameter retrieval Dec 15, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMParametersByPathDataSource_' PKG_NAME=internal/service/ssm
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run=TestAccSSMParametersByPathDataSource_ -timeout 180m
=== RUN   TestAccSSMParametersByPathDataSource_basic
=== PAUSE TestAccSSMParametersByPathDataSource_basic
=== RUN   TestAccSSMParametersByPathDataSource_withRecursion
=== PAUSE TestAccSSMParametersByPathDataSource_withRecursion
=== CONT  TestAccSSMParametersByPathDataSource_basic
=== CONT  TestAccSSMParametersByPathDataSource_withRecursion
--- PASS: TestAccSSMParametersByPathDataSource_withRecursion (16.84s)
--- PASS: TestAccSSMParametersByPathDataSource_basic (16.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	20.553s

@ewbankkit
Copy link
Contributor

@sjonpaulbrown Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit c7157da into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for recursive flag on datasource aws_ssm_parameters_by_path
2 participants