Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fsx ontap_storage_virtual_machine resource #21780

Merged

Conversation

awsaxeman
Copy link
Contributor

@awsaxeman awsaxeman commented Nov 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20778

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccFSxOntapStorageVirtualMachine' PKG_NAME=internal/service/fsx

=== CONT  TestAccFSxOntapStorageVirtualMachine_name
--- PASS: TestAccFSxOntapStorageVirtualMachine_name (3020.50s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
--- PASS: TestAccFSxOntapStorageVirtualMachine_svmAdminPassword (2729.62s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_basic
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (2544.48s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
--- PASS: TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle (2697.35s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_disappears
--- PASS: TestAccFSxOntapStorageVirtualMachine_disappears (2693.69s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_activeDirectory
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2808.88s)
=== CONT  TestAccFSxOntapStorageVirtualMachine_tags
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (3565.28s)
...

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 15, 2021
@ewbankkit
Copy link
Contributor

Similar: #21503.

@awsaxeman awsaxeman changed the title [WIP] Add fsx ontap_storage_virtual_machine resource Add fsx ontap_storage_virtual_machine resource Nov 18, 2021
@awsaxeman awsaxeman marked this pull request as ready for review November 18, 2021 18:33
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 18, 2021
@DrFaust92
Copy link
Collaborator

Code wise looks good to me, ill try to run tests in the coming days.

@DrFaust92 DrFaust92 removed the service/ec2 Issues and PRs that pertain to the ec2 service. label Nov 24, 2021
@breathingdust
Copy link
Member

Validated tests in Commercial us-west-2

make testacc TESTARGS='-run=TestAccFSxOntapStorageVirtualMachine' PKG_NAME=internal/service/fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxOntapStorageVirtualMachine -timeout 180m
=== RUN   TestAccFSxOntapStorageVirtualMachine_basic
=== PAUSE TestAccFSxOntapStorageVirtualMachine_basic
=== RUN   TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
=== PAUSE TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
=== RUN   TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== PAUSE TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== RUN   TestAccFSxOntapStorageVirtualMachine_disappears
=== PAUSE TestAccFSxOntapStorageVirtualMachine_disappears
=== RUN   TestAccFSxOntapStorageVirtualMachine_name
=== PAUSE TestAccFSxOntapStorageVirtualMachine_name
=== RUN   TestAccFSxOntapStorageVirtualMachine_tags
=== PAUSE TestAccFSxOntapStorageVirtualMachine_tags
=== RUN   TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== PAUSE TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== CONT  TestAccFSxOntapStorageVirtualMachine_basic
=== CONT  TestAccFSxOntapStorageVirtualMachine_name
=== CONT  TestAccFSxOntapStorageVirtualMachine_disappears
=== CONT  TestAccFSxOntapStorageVirtualMachine_tags
=== CONT  TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== CONT  TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
=== CONT  TestAccFSxOntapStorageVirtualMachine_activeDirectory
--- PASS: TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle (2561.47s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (2601.37s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_disappears (2650.53s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2683.11s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_svmAdminPassword (2689.35s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (2724.07s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_name (3107.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	3110.620s

Validated Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccFSxOntapStorageVirtualMachine' PKG_NAME=internal/service/fsx
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 20 -run=TestAccFSxOntapStorageVirtualMachine -timeout 180m
=== RUN   TestAccFSxOntapStorageVirtualMachine_basic
=== PAUSE TestAccFSxOntapStorageVirtualMachine_basic
=== RUN   TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
=== PAUSE TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
=== RUN   TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== PAUSE TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== RUN   TestAccFSxOntapStorageVirtualMachine_disappears
=== PAUSE TestAccFSxOntapStorageVirtualMachine_disappears
=== RUN   TestAccFSxOntapStorageVirtualMachine_name
=== PAUSE TestAccFSxOntapStorageVirtualMachine_name
=== RUN   TestAccFSxOntapStorageVirtualMachine_tags
=== PAUSE TestAccFSxOntapStorageVirtualMachine_tags
=== RUN   TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== PAUSE TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== CONT  TestAccFSxOntapStorageVirtualMachine_basic
=== CONT  TestAccFSxOntapStorageVirtualMachine_name
=== CONT  TestAccFSxOntapStorageVirtualMachine_svmAdminPassword
=== CONT  TestAccFSxOntapStorageVirtualMachine_activeDirectory
=== CONT  TestAccFSxOntapStorageVirtualMachine_tags
=== CONT  TestAccFSxOntapStorageVirtualMachine_disappears
=== CONT  TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle
--- PASS: TestAccFSxOntapStorageVirtualMachine_tags (2406.80s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_svmAdminPassword (2427.79s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_rootVolumeSecurityStyle (2457.69s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_disappears (2610.12s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_basic (2713.25s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_activeDirectory (2849.83s)
--- PASS: TestAccFSxOntapStorageVirtualMachine_name (2902.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	2905.325s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @awsaxeman!

@gdavison
Copy link
Contributor

Hi @DrFaust92 and @awsaxeman. In #21922, I've added the sweeper function sweepFSXOntapStorageVirtualMachine that's referenced in this PR, but isn't defined. Unfortunately, because of how the sweepers are implemented with build tags, the sweeper functions don't get compiled until they are run.

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants