Add parameter build_type to codebuild_webhook

[tatsuya-ogawa]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$make testacc TESTARGS='-run=TestAccAWSCodeBuildWebhook_BuildType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildWebhook_BuildType -timeout 180m
=== RUN   TestAccAWSCodeBuildWebhook_BuildType
=== PAUSE TestAccAWSCodeBuildWebhook_BuildType
=== CONT  TestAccAWSCodeBuildWebhook_BuildType
--- PASS: TestAccAWSCodeBuildWebhook_BuildType (92.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	93.776s

Closes #16824

[github-actions]

Welcome @tatsuya-ogawa 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

AWS_CODEBUILD_GITHUB_SOURCE_LOCATION=... make testacc TESTARGS='-run=TestAccAWSCodeBuildWebhook_GitHub\|TestAccAWSCodeBuildWebhook_BuildType'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildWebhook_GitHub\|TestAccAWSCodeBuildWebhook_BuildType -timeout 180m
=== RUN   TestAccAWSCodeBuildWebhook_GitHub
=== PAUSE TestAccAWSCodeBuildWebhook_GitHub
=== RUN   TestAccAWSCodeBuildWebhook_BuildType
=== PAUSE TestAccAWSCodeBuildWebhook_BuildType
=== CONT  TestAccAWSCodeBuildWebhook_GitHub
=== CONT  TestAccAWSCodeBuildWebhook_BuildType
--- PASS: TestAccAWSCodeBuildWebhook_GitHub (27.28s)
--- PASS: TestAccAWSCodeBuildWebhook_BuildType (37.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws       42.761s

[ewbankkit]

@tatsuya-ogawa Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[jebl01]

@ewbankkit not specifying build_type (optional according to the doc) produces an invalid request to AWS ("buildType":"") making the apply fail :-(

I started writing a bug report, but gave up at trying to provide a full working example...

[tatsuya-ogawa]

@ewbankkit not specifying build_type (optional according to the doc) produces an invalid request to AWS ("buildType":"") making the apply fail :-(

I started writing a bug report, but gave up at trying to provide a full working example...

It seems d.Get("build_type") return blank string if key does not exists.
I created a bugfix pr to check the key build_type exists.
#20671

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.