r/servicecatalog_provisioned_product: New resource

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19470, #19572, #19957

Output from acceptance testing ('us-west-2'):

--- PASS: TestAccAWSServiceCatalogProvisionedProduct_disappears (114.22s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_basic (114.83s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_tags (308.38s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogProvisionedProduct_disappears (111.47s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_basic (113.93s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_tags (178.93s)

References

• See servicecatalog.PrincipalARN contains principal's unique ID, not ARN aws/aws-sdk-go#3920

[ewbankkit]

The underlying API field for this (and other attributes in this block) is named StackSetAccount - Consider renaming to stack_set_account?

[YakDriver]

Instead of rename each of the arguments in the provisioning_preferences block, which seems redundant, repeated, and repetitive, I renamed the block to stack_set_provisioning_preferences. What do you think?

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogProvisionedProduct_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_basic
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_tags
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_basic
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_tags
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_disappears (145.86s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_basic (168.31s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_tags (259.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	262.320s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogProvisionedProduct_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_basic
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccAWSServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccAWSServiceCatalogProvisionedProduct_tags
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_basic
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_tags
=== CONT  TestAccAWSServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_disappears (153.64s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_basic (162.34s)
--- PASS: TestAccAWSServiceCatalogProvisionedProduct_tags (271.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	274.594s

[github-actions]

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.