Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: addition of "tags_all" to resource Update functions using d.HasChangesExcept("tags"...) and d.HasChangeExcept #19086

Merged
merged 2 commits into from
Apr 23, 2021
Merged

resources: addition of "tags_all" to resource Update functions using d.HasChangesExcept("tags"...) and d.HasChangeExcept #19086

merged 2 commits into from
Apr 23, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7926

Output from acceptance testing:

Will depend on CI nightly test results

@anGie44 anGie44 requested a review from a team as a code owner April 23, 2021 17:50
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/mwaa Issues and PRs that pertain to the mwaa service. service/ssm Issues and PRs that pertain to the ssm service. service/synthetics Issues and PRs that pertain to the synthetics service. labels Apr 23, 2021
@anGie44 anGie44 changed the title resources: addition of "tags_all" to resource Update functions using d.HasChangesExcept("tags"...) resources: addition of "tags_all" to resource Update functions using d.HasChangesExcept("tags"...) and d.HasChangeExcept Apr 23, 2021
ewbankkit
ewbankkit approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v3.38.0 milestone Apr 23, 2021
@anGie44 anGie44 merged commit 244a32f into main Apr 23, 2021
@anGie44 anGie44 deleted the td-resource-update-with-has-changes-except-clean-up branch April 23, 2021 19:37
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. service/mwaa Issues and PRs that pertain to the mwaa service. service/ssm Issues and PRs that pertain to the ssm service. service/synthetics Issues and PRs that pertain to the synthetics service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit