Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Support default tags (resources aws_k*) #18727

Merged
merged 11 commits into from
Apr 24, 2021
Merged

provider: Support default tags (resources aws_k*) #18727

merged 11 commits into from
Apr 24, 2021

Conversation

breathingdust
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #7926

Output from acceptance testing: Will be handled via CI, review, and daily acceptance testing

@breathingdust breathingdust requested a review from a team as a code owner April 9, 2021 20:55
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. service/firehose Issues and PRs that pertain to the firehose service. service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/kms Issues and PRs that pertain to the kms service. labels Apr 9, 2021
@ewbankkit ewbankkit self-assigned this Apr 19, 2021
ewbankkit
ewbankkit approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 removed the documentation Introduces or discusses updates to documentation. label Apr 23, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 23, 2021
anGie44
anGie44 approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@anGie44 anGie44 added this to the v3.38.0 milestone Apr 24, 2021
@anGie44 anGie44 merged commit 4ea3740 into main Apr 24, 2021
@anGie44 anGie44 deleted the defaulttags/k branch April 24, 2021 00:38
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@anGie44 anGie44 anGie44 approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. service/firehose Issues and PRs that pertain to the firehose service. service/kinesis Issues and PRs that pertain to the kinesis service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/kms Issues and PRs that pertain to the kms service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@breathingdust @ewbankkit @anGie44