Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Support default tags (resources aws_i*) #18723

Merged
merged 5 commits into from
Apr 21, 2021
Merged

provider: Support default tags (resources aws_i*) #18723

merged 5 commits into from
Apr 21, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #7926

Output from acceptance testing: Will be handled via CI, review, and daily acceptance testing

@bflad bflad requested a review from a team as a code owner April 9, 2021 19:25
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 9, 2021
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/inspector Issues and PRs that pertain to the inspector service. service/iot Issues and PRs that pertain to the iot service. labels Apr 9, 2021
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Apr 12, 2021
anGie44
anGie44 approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(merge conflict to address..otherwise LGTM 👍 )

bflad
bflad commented Apr 19, 2021
View reviewed changes
aws/resource_aws_iam_policy.go Outdated Show resolved Hide resolved
anGie44
anGie44 reviewed Apr 20, 2021
View reviewed changes
aws/resource_aws_iam_instance_profile.go
Comment on lines +72 to +73
"tags": tagsSchema(),
"tags_all": tagsSchemaComputed(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooo i missed on first review @bflad: just need to update this resource's Read method to set these attributes, hidden in the instanceProfileReadResult func

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 7dc456f

anGie44
anGie44 reviewed Apr 20, 2021
View reviewed changes
aws/resource_aws_imagebuilder_image.go
Comment on lines +137 to +138
"tags": tagsSchema(),
"tags_all": tagsSchemaComputed(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed on first review @bflad: just need to update this resource's Read method to set these attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 7dc456f

anGie44
anGie44 reviewed Apr 20, 2021
View reviewed changes
aws/resource_aws_imagebuilder_image_pipeline.go
Comment on lines +130 to +131
"tags": tagsSchema(),
"tags_all": tagsSchemaComputed(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed on first review @bflad: just need to update this resource's Read method to set these attributes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 7dc456f

@bflad bflad merged commit 83a19e7 into main Apr 21, 2021
@bflad bflad deleted the f-default-tags-i branch April 21, 2021 17:00
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 21, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/inspector Issues and PRs that pertain to the inspector service. service/iot Issues and PRs that pertain to the iot service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44