Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ssm_parameter - tag on create + validations #17830

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17819

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMParameter_'
--- PASS: TestAccAWSSSMParameter_disappears (39.90s)
--- PASS: TestAccAWSSSMParameter_secure (62.44s)
--- PASS: TestAccAWSSSMParameter_basic (62.61s)
--- PASS: TestAccAWSSSMParameter_fullPath (63.02s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (68.32s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (77.85s)
--- PASS: TestAccAWSSSMParameter_updateDescription (90.66s)
--- PASS: TestAccAWSSSMParameter_overwrite (94.95s)
--- PASS: TestAccAWSSSMParameter_updateType (96.96s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (99.72s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (115.52s)
--- PASS: TestAccAWSSSMParameter_Tier (129.45s)
--- PASS: TestAccAWSSSMParameter_tags (131.75s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner February 25, 2021 20:34
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ssm Issues and PRs that pertain to the ssm service. labels Feb 25, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 25, 2021
@bflad bflad self-assigned this Mar 25, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMParameter_disappears (35.77s)
--- PASS: TestAccAWSSSMParameter_fullPath (51.23s)
--- PASS: TestAccAWSSSMParameter_basic (51.86s)
--- PASS: TestAccAWSSSMParameter_secure (52.09s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (58.46s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (60.49s)
--- PASS: TestAccAWSSSMParameter_overwrite (77.69s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (82.64s)
--- PASS: TestAccAWSSSMParameter_updateDescription (82.84s)
--- PASS: TestAccAWSSSMParameter_updateType (83.08s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (85.13s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (93.66s)
--- PASS: TestAccAWSSSMParameter_tags (94.47s)
--- PASS: TestAccAWSSSMParameter_Tier (96.68s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (98.75s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMParameter_disappears (40.39s)
--- PASS: TestAccAWSSSMParameter_fullPath (59.78s)
--- PASS: TestAccAWSSSMParameter_secure (59.78s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (59.81s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (59.87s)
--- PASS: TestAccAWSSSMParameter_basic (59.88s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (77.00s)
--- PASS: TestAccAWSSSMParameter_updateDescription (83.65s)
--- PASS: TestAccAWSSSMParameter_overwrite (84.29s)
--- PASS: TestAccAWSSSMParameter_updateType (84.34s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (85.81s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (97.59s)
--- PASS: TestAccAWSSSMParameter_tags (100.37s)
--- PASS: TestAccAWSSSMParameter_Tier (100.40s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (103.42s)

@bflad bflad merged commit 7a8be07 into hashicorp:main Mar 26, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 26, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@razorsedge
Copy link

As per the docs, allowed_pattern and description should be minimum of 0.

@denisbr
Copy link

denisbr commented Apr 6, 2021

This broke a bunch of pipelines on our end. As @razorsedge mentions, description is allowed to be 0, not minimum 1 char.

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags should be passed to SSM PutParameter
4 participants