-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data.aws_launch_template acceptance test regressions #16360
Fix data.aws_launch_template acceptance test regressions #16360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @hansnielsen 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Hi @hansnielsen 👋 Thank you for providing these testing adjustments and sorry for the hassle here. This testing issue unfortunately breaks Terraform 0.12.x testing, which we have kept as our default Terraform CLI version for now knowing this type of issue will resolve itself again with Terraform 0.14 coming in roughly 2 weeks. Rather than break our testing in the opposite direction since we will want to keep running regression testing for 0.12.x until we phase out provider support for that version, we are opting to keep To temporarily workaround this issue until Terraform 0.14 is out, you can tell the acceptance testing to use a different Terraform CLI binary with the A real fix for the ~150+ tests affected by this issue would be splitting the |
Good to know! For the other PR I submitted that relies on this behavior (#16361), do you have an example of how to split this test so that it doesn't rely on |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
This PR fixes some acceptance tests that no longer work as of Terraform v0.13.5.
Original (broken) acceptance testing output:
Output from acceptance testing: