Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_code_repository - new resource #15809

Merged
merged 24 commits into from
Oct 29, 2020
Merged

r/sagemaker_code_repository - new resource #15809

merged 24 commits into from
Oct 29, 2020

Commits on Oct 29, 2020

  1.  add sagemaker code repository

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2cbbb89 View commit details
    Browse the repository at this point in the history

  2. add test for branch and secret

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    62d6e87 View commit details
    Browse the repository at this point in the history

  3. add examples to docs

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    dfd953a View commit details
    Browse the repository at this point in the history

  4. update secret test

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    605f6f3 View commit details
    Browse the repository at this point in the history

  5. lint

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    0959b4d View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Kit Ewbank <[email protected]>
    @DrFaust92 @ewbankkit
    DrFaust92 and ewbankkit committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    ffce96b View commit details
    Browse the repository at this point in the history

  7. no need for err chcek for simple type

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    f11b7c0 View commit details
    Browse the repository at this point in the history

  8. no need for err check for simple type

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    30ddf6a View commit details
    Browse the repository at this point in the history

  9. add validation to name

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    13fa67f View commit details
    Browse the repository at this point in the history

  10. extract code repo finder func to separate package

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    0271641 View commit details
    Browse the repository at this point in the history

  11. use correct package

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    96e84f7 View commit details
    Browse the repository at this point in the history

  12. use correct input

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    ac4649e View commit details
    Browse the repository at this point in the history

  13. fix resp

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    b0f4fa2 View commit details
    Browse the repository at this point in the history

  14. docs lint

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    817667c View commit details
    Browse the repository at this point in the history

  15. docs tf fmt docs

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    6ec0f49 View commit details
    Browse the repository at this point in the history

  16. lint docs

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    b8946bf View commit details
    Browse the repository at this point in the history

  17. lint

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    080fe42 View commit details
    Browse the repository at this point in the history

  18. lint test config

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    93ab97d View commit details
    Browse the repository at this point in the history

  19. last lint

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    1df812a View commit details
    Browse the repository at this point in the history

  20. add sagemaker instance test for repo resource

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c408b8c View commit details
    Browse the repository at this point in the history

  21. add notebook instance example in docs

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a341c8b View commit details
    Browse the repository at this point in the history

  22. Update aws/internal/service/sagemaker/finder/finder.go 

    Co-authored-by: Kit Ewbank <[email protected]>
    @DrFaust92 @ewbankkit
    DrFaust92 and ewbankkit committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    df16704 View commit details
    Browse the repository at this point in the history

  23. use short name

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    7c4e13a View commit details
    Browse the repository at this point in the history

  24. use right func

    @DrFaust92
    DrFaust92 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    bbfe5c4 View commit details
    Browse the repository at this point in the history