resource/aws_redshift_cluster: Increase default Update timeout to 75 minutes and remove arbitrary lower create timeout in testing

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14754

Release note for CHANGELOG:

* resource/aws_redshift_cluster: Increase default update timeout to 75 minutes

Previously (inconsistently):

=== CONT  TestAccAWSRedshiftCluster_basic
TestAccAWSRedshiftCluster_basic: resource_aws_redshift_cluster_test.go:69: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_changeEncryption1
TestAccAWSRedshiftCluster_changeEncryption1: resource_aws_redshift_cluster_test.go:526: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeType
TestAccAWSRedshiftCluster_updateNodeType: resource_aws_redshift_cluster_test.go:390: Step 1/2 error: terraform failed: exit status 1
stderr:
Error: Error waiting for Redshift Cluster state to be "available": timeout while waiting for state to become 'available' (last state: 'creating', timeout: 30m0s)

=== CONT  TestAccAWSRedshiftCluster_updateNodeCount
TestAccAWSRedshiftCluster_updateNodeCount: resource_aws_redshift_cluster_test.go:353: Step 2/2 error: terraform failed: exit status 1
stderr:
Error: Error Modifying Redshift Cluster (tf-redshift-cluster-7778138192916979662): timeout while waiting for state to become 'available' (last state: 'resizing', timeout: 40m0s)

The 75 minute update timeout value is chosen to match the create timeout value.

Output from acceptance testing:

--- PASS: TestAccAWSRedshiftCluster_loggingEnabled (373.42s)
--- PASS: TestAccAWSRedshiftCluster_basic (789.01s)
--- PASS: TestAccAWSRedshiftCluster_kmsKey (792.82s)
--- PASS: TestAccAWSRedshiftCluster_forceNewUsername (960.36s)
--- PASS: TestAccAWSRedshiftCluster_snapshotCopy (1111.85s)
--- PASS: TestAccAWSRedshiftCluster_enhancedVpcRoutingEnabled (1275.44s)
--- PASS: TestAccAWSRedshiftCluster_changeAvailabilityZone (1290.59s)
--- PASS: TestAccAWSRedshiftCluster_iamRoles (1320.91s)
--- PASS: TestAccAWSRedshiftCluster_tags (1501.17s)
--- PASS: TestAccAWSRedshiftCluster_withFinalSnapshot (1502.53s)
--- PASS: TestAccAWSRedshiftCluster_publiclyAccessible (1512.02s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeType (2246.61s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption1 (2506.37s)
--- PASS: TestAccAWSRedshiftCluster_changeEncryption2 (3070.55s)
--- PASS: TestAccAWSRedshiftCluster_updateNodeCount (3251.04s)

[anGie44]

LGTM 👍

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!