[READY] fix: vpcs datasource returns empty list when no vpcs

[bcatubig]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #13951

Release note for CHANGELOG:

- aws_vpcs data source now returns an empty list instead of an error when no vpcs exist in an aws account

Output from acceptance testing:

➜ make testacc TESTARGS='-run=TestAccDataSourceAwsVpcs_'                                           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcs_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccDataSourceAwsVpcs_basic
=== PAUSE TestAccDataSourceAwsVpcs_basic
=== RUN   TestAccDataSourceAwsVpcs_tags
=== PAUSE TestAccDataSourceAwsVpcs_tags
=== RUN   TestAccDataSourceAwsVpcs_filters
=== PAUSE TestAccDataSourceAwsVpcs_filters
=== RUN   TestAccDataSourceAwsVpcs_empty
=== PAUSE TestAccDataSourceAwsVpcs_empty
=== CONT  TestAccDataSourceAwsVpcs_basic
=== CONT  TestAccDataSourceAwsVpcs_empty
=== CONT  TestAccDataSourceAwsVpcs_filters
=== CONT  TestAccDataSourceAwsVpcs_tags
--- PASS: TestAccDataSourceAwsVpcs_empty (21.87s)
--- PASS: TestAccDataSourceAwsVpcs_basic (27.54s)
--- PASS: TestAccDataSourceAwsVpcs_tags (28.05s)
--- PASS: TestAccDataSourceAwsVpcs_filters (28.29s)

[petems]

@bcatubig I think putting this behind a flag with a parameter would make more sense, rather than changing the default behavior.

Something like:

data "aws_vpcs" "all" {
  error_on_no_results = false
}

NB: These are my 2 cents, I'm not speaking for the team or anything 😄

[ewbankkit]

Relates:

• Feature Request: Allow data sources searching tags/filters to return empty results #8302

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.