Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CronExpression to DLM Lifecycle Policy #13889

Conversation

niklaskhf
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13627

Release note for CHANGELOG:

Add support for CronExpression in `resource_dlm_lifecycle_policy`. 

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDlmLifecyclePolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDlmLifecyclePolicy -timeout 120m
=== RUN   TestAccAWSDlmLifecyclePolicy_Basic
=== PAUSE TestAccAWSDlmLifecyclePolicy_Basic
=== RUN   TestAccAWSDlmLifecyclePolicy_Full
=== PAUSE TestAccAWSDlmLifecyclePolicy_Full
=== RUN   TestAccAWSDlmLifecyclePolicy_Tags
=== PAUSE TestAccAWSDlmLifecyclePolicy_Tags
=== CONT  TestAccAWSDlmLifecyclePolicy_Basic
=== CONT  TestAccAWSDlmLifecyclePolicy_Tags
=== CONT  TestAccAWSDlmLifecyclePolicy_Full
--- PASS: TestAccAWSDlmLifecyclePolicy_Basic (40.35s)
--- PASS: TestAccAWSDlmLifecyclePolicy_Tags (65.30s)
--- PASS: TestAccAWSDlmLifecyclePolicy_Full (92.94s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       95.211s

...

@niklaskhf niklaskhf requested a review from a team June 23, 2020 07:16
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dlm Issues and PRs that pertain to the dlm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 23, 2020
@niklaskhf niklaskhf changed the title F aws dlm lifecycle policy cron expression Add CronExpression to DLM Lifecycle Policy Jun 23, 2020
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit
Copy link
Contributor

@niklaskhf Thanks for the contribution 🎉 👏.
These changes have been rolled into #23880.

@ewbankkit ewbankkit closed this Mar 28, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLM Lifecycle Policy CronExpression support
4 participants