Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource aws_route53domains_domain #12711

Merged
merged 53 commits into from
Mar 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
e8f9732
r/aws_route53_domain: New aws_route53_domain resource
gazoakley Aug 26, 2019
97aae10
r/aws_route53_domain: Fix tagging for aws_route53_domain
gazoakley Aug 26, 2019
3043a40
r/aws_route53_domain: Allow updating name servers
gazoakley Aug 26, 2019
d7903f7
r/aws_route53_domain: Initial documentation
gazoakley Apr 13, 2020
76682d4
r/aws_route53domains_domain: Rename from r/aws_route53_domain
gazoakley Apr 25, 2020
75e90f7
r/aws_route53domains_domain: Add support for route53domains to keyval…
gazoakley Apr 25, 2020
8bef39a
r/aws_route53domains_domain: Resolve build failures, use keyvaluetags…
gazoakley Apr 25, 2020
0a5e4f7
r/aws_route53domains_domain: Lint fixes
gazoakley Apr 25, 2020
28fdd45
r/aws_route53domains_domain: Initial tests, update docs, fix to alway…
gazoakley Apr 26, 2020
2d1aa4c
Revert "r/aws_route53domains_domain: Initial tests, update docs, fix …
ewbankkit Feb 9, 2022
4563525
Revert "r/aws_route53domains_domain: Lint fixes"
ewbankkit Feb 9, 2022
9f66eda
Revert "r/aws_route53domains_domain: Resolve build failures, use keyv…
ewbankkit Feb 9, 2022
d5b80b9
Revert "r/aws_route53domains_domain: Add support for route53domains t…
ewbankkit Feb 9, 2022
6bd265a
Revert "r/aws_route53domains_domain: Rename from r/aws_route53_domain"
ewbankkit Feb 9, 2022
9b664ae
Revert "r/aws_route53_domain: Initial documentation"
ewbankkit Feb 9, 2022
1953d82
Revert "r/aws_route53_domain: Allow updating name servers"
ewbankkit Feb 9, 2022
baa518a
Revert "r/aws_route53_domain: Fix tagging for aws_route53_domain"
ewbankkit Feb 9, 2022
beb3431
Revert "r/aws_route53_domain: New aws_route53_domain resource"
ewbankkit Feb 9, 2022
d3d75ad
Merge branch 'main' into HEAD
ewbankkit Feb 9, 2022
63fe272
Corrections to tag generator documentation.
ewbankkit Feb 9, 2022
0c2ff4f
Add Route 53 Domains tagging.
ewbankkit Feb 9, 2022
adae6a4
r/aws_route53domains_registered_domain: Skeleton of new resource.
ewbankkit Feb 9, 2022
892dbb1
r/aws_route53domains_registered_domain: Start to add tagging support.
ewbankkit Feb 9, 2022
15ebbd9
r/aws_route53domains_registered_domain: Continue tagging support.
ewbankkit Feb 10, 2022
038b9cb
r/aws_route53domains_registered_domain: Test tags.
ewbankkit Feb 10, 2022
9c9eaca
r/aws_route53domains_registered_domain: Add 'name_servers'.
ewbankkit Feb 11, 2022
8150451
r/aws_route53domains_registered_domain: Test name servers.
ewbankkit Feb 13, 2022
ecee6da
r/aws_route53domains_registered_domain: Add 'auto_renew'.
ewbankkit Feb 13, 2022
0362030
r/aws_route53domains_registered_domain: Additional computed attributes.
ewbankkit Feb 14, 2022
463d1f9
r/aws_route53domains_registered_domain: Add contact privacy.
ewbankkit Feb 14, 2022
d99c757
r/aws_route53domains_registered_domain: Add transfer lock.
ewbankkit Feb 14, 2022
603c354
r/aws_route53domains_registered_domain: Add reading of contacts.
ewbankkit Feb 14, 2022
5779676
r/aws_route53domains_registered_domain: Add updating of contacts.
ewbankkit Feb 14, 2022
4567b21
Fix terrafmt errors.
ewbankkit Feb 14, 2022
efd184a
Fix tag generator documentation links.
ewbankkit Feb 14, 2022
1328b65
Don't run 'go test' for packages below 'internal/generate'.
ewbankkit Feb 14, 2022
c056aec
Add 'ROUTE53DOMAINS_DOMAIN_NAME' to environment variable dictionary.
ewbankkit Feb 14, 2022
1e0062e
Add 'nolint:unparam'.
ewbankkit Feb 14, 2022
48caafb
r/aws_route53domains_registered_domain: Use `WithoutTimeout` CRUD han…
ewbankkit Feb 15, 2022
ff68104
Run 'go get github.com/aws/aws-sdk-go-v2/service/[email protected]'.
ewbankkit Feb 15, 2022
b31499c
Use AWS Go SDK v2 client for Route 53 Domains.
ewbankkit Feb 15, 2022
73ac0d7
Hand massage tagging code for AWS Go SDK v2.
ewbankkit Feb 15, 2022
65c0fd8
r/aws_route53domains_registered_domain: Migrate to AWS Go SDK v2.
ewbankkit Feb 15, 2022
09d30c6
Merge branch 'main' into HEAD
ewbankkit Feb 16, 2022
f78b8ff
Fix sweeper client initialization.
ewbankkit Feb 16, 2022
53aab00
Prefer 'diag.Errorf()' over 'diag.FromError(fmt.Errorf())'.
ewbankkit Feb 24, 2022
8f246e1
Use 'route53domains.EndpointResolverFromURL'.
ewbankkit Feb 24, 2022
b754359
Remove 'TODO's.
ewbankkit Feb 25, 2022
ea185e0
r/aws_route53domains_registered_domain: Return warning diagnostic rat…
ewbankkit Feb 25, 2022
ae248e2
Merge branch 'main' into HEAD
ewbankkit Feb 25, 2022
baacd6c
r/aws_route53domains_registered_domain: Contact attributes are all Co…
ewbankkit Feb 25, 2022
bd272a5
Merge branch 'main' into HEAD
ewbankkit Feb 28, 2022
0f580bc
Merge branch 'main' into HEAD
ewbankkit Mar 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/12711.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_route53domains_registered_domain
```
10 changes: 5 additions & 5 deletions docs/contributing/contribution-checklists.md
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ More details about this code generation, including fixes for potential error mes
func ResourceCluster() *schema.Resource {
return &schema.Resource{
/* ... other configuration ... */
CustomizeDiff: SetTagsDiff,
CustomizeDiff: verify.SetTagsDiff,
}
}
```
Expand Down Expand Up @@ -361,7 +361,7 @@ More details about this code generation, including fixes for potential error mes

if len(tags) > 0 {
if err := UpdateTags(conn, d.Id(), nil, tags); err != nil {
return fmt.Errorf("error adding Elasticsearch Cluster (%s) tags: %s", d.Id(), err)
return fmt.Errorf("error adding Elasticsearch Cluster (%s) tags: %w", d.Id(), err)
}
}
```
Expand Down Expand Up @@ -411,7 +411,7 @@ More details about this code generation, including fixes for potential error mes
tags, err := keyvaluetags.AthenaListTags(conn, arn.String())

if err != nil {
return fmt.Errorf("error listing tags for resource (%s): %s", arn, err)
return fmt.Errorf("error listing tags for resource (%s): %w", arn, err)
}

tags = tags.IgnoreAws().IgnoreConfig(ignoreTagsConfig)
Expand All @@ -431,7 +431,7 @@ More details about this code generation, including fixes for potential error mes
if d.HasChange("tags_all") {
o, n := d.GetChange("tags_all")
if err := keyvaluetags.EksUpdateTags(conn, d.Get("arn").(string), o, n); err != nil {
return fmt.Errorf("error updating tags: %s", err)
return fmt.Errorf("error updating tags: %w", err)
}
}
```
Expand All @@ -448,7 +448,7 @@ More details about this code generation, including fixes for potential error mes
}

if _, err := conn.CreatePolicyVersion(request); err != nil {
return fmt.Errorf("error updating IAM policy %s: %w", d.Id(), err)
return fmt.Errorf("error updating IAM policy (%s): %w", d.Id(), err)
}
}
```
Expand Down
1 change: 1 addition & 0 deletions docs/contributing/maintaining.md
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ Environment variables (beyond standard AWS Go SDK ones) used by acceptance testi
| `GCM_API_KEY` | API Key for Google Cloud Messaging in Pinpoint and SNS Platform Application testing. |
| `GITHUB_TOKEN` | GitHub token for CodePipeline testing. |
| `MACIE_MEMBER_ACCOUNT_ID` | Identifier of AWS Account for Macie Member testing. **DEPRECATED:** Should be replaced with standard alternate account handling for tests. |
| `ROUTE53DOMAINS_DOMAIN_NAME` | Registered domain for Route 53 Domains testing. |
| `SAGEMAKER_IMAGE_VERSION_BASE_IMAGE` | Sagemaker base image to use for tests. |
| `SERVICEQUOTAS_INCREASE_ON_CREATE_QUOTA_CODE` | Quota Code for Service Quotas testing (submits support case). |
| `SERVICEQUOTAS_INCREASE_ON_CREATE_SERVICE_CODE` | Service Code for Service Quotas testing (submits support case). |
Expand Down
3 changes: 2 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ go 1.17
require (
github.com/ProtonMail/go-crypto v0.0.0-20210428141323-04723f9f07d7
github.com/aws/aws-sdk-go v1.43.8
github.com/aws/aws-sdk-go-v2 v1.13.0
github.com/aws/aws-sdk-go-v2/service/route53domains v1.8.0
github.com/beevik/etree v1.1.0
github.com/google/go-cmp v0.5.7
github.com/hashicorp/aws-cloudformation-resource-schema-sdk-go v0.16.0
Expand Down Expand Up @@ -32,7 +34,6 @@ require (
github.com/apparentlymart/go-cidr v1.0.1 // indirect
github.com/apparentlymart/go-textseg v1.0.0 // indirect
github.com/apparentlymart/go-textseg/v13 v13.0.0 // indirect
github.com/aws/aws-sdk-go-v2 v1.13.0 // indirect
github.com/aws/aws-sdk-go-v2/config v1.13.1 // indirect
github.com/aws/aws-sdk-go-v2/credentials v1.8.0 // indirect
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.10.0 // indirect
Expand Down
6 changes: 6 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ github.com/aws/aws-sdk-go v1.42.18/go.mod h1:585smgzpB/KqRA+K3y/NL/oYRqQvpNJYvLm
github.com/aws/aws-sdk-go v1.42.52/go.mod h1:OGr6lGMAKGlG9CVrYnWYDKIyb829c6EVBRjxqjmPepc=
github.com/aws/aws-sdk-go v1.43.8 h1:8a/M9C4l5CxFNM6IuNx4F1p+ITJEX12VxWxUQo61cbc=
github.com/aws/aws-sdk-go v1.43.8/go.mod h1:y4AeaBuwd2Lk+GepC1E9v0qOiTws0MIWAX4oIKwKHZo=
github.com/aws/aws-sdk-go-v2 v1.11.2/go.mod h1:SQfA+m2ltnu1cA0soUkj4dRSsmITiVQUJvBIZjzfPyQ=
github.com/aws/aws-sdk-go-v2 v1.13.0 h1:1XIXAfxsEmbhbj5ry3D3vX+6ZcUYvIqSm4CWWEuGZCA=
github.com/aws/aws-sdk-go-v2 v1.13.0/go.mod h1:L6+ZpqHaLbAaxsqV0L4cvxZY7QupWJB4fhkf8LXvC7w=
github.com/aws/aws-sdk-go-v2/config v1.13.1 h1:yLv8bfNoT4r+UvUKQKqRtdnvuWGMK5a82l4ru9Jvnuo=
Expand All @@ -75,8 +76,10 @@ github.com/aws/aws-sdk-go-v2/credentials v1.8.0 h1:8Ow0WcyDesGNL0No11jcgb1JAtE+W
github.com/aws/aws-sdk-go-v2/credentials v1.8.0/go.mod h1:gnMo58Vwx3Mu7hj1wpcG8DI0s57c9o42UQ6wgTQT5to=
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.10.0 h1:NITDuUZO34mqtOwFWZiXo7yAHj7kf+XPE+EiKuCBNUI=
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.10.0/go.mod h1:I6/fHT/fH460v09eg2gVrd8B/IqskhNdpcLH0WNO3QI=
github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.2/go.mod h1:SgKKNBIoDC/E1ZCDhhMW3yalWjwuLjMcpLzsM/QQnWo=
github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.4 h1:CRiQJ4E2RhfDdqbie1ZYDo8QtIo75Mk7oTdJSfwJTMQ=
github.com/aws/aws-sdk-go-v2/internal/configsources v1.1.4/go.mod h1:XHgQ7Hz2WY2GAn//UXHofLfPXWh+s62MbMOijrg12Lw=
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.0.2/go.mod h1:xT4XX6w5Sa3dhg50JrYyy3e4WPYo/+WjY/BXtqXVunU=
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.2.0 h1:3ADoioDMOtF4uiK59vCpplpCwugEU+v4ZFD29jDL3RQ=
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.2.0/go.mod h1:BsCSJHx5DnDXIrOcqB8KN1/B+hXLG/bi4Y6Vjcx/x9E=
github.com/aws/aws-sdk-go-v2/internal/ini v1.3.5 h1:ixotxbfTCFpqbuwFv/RcZwyzhkxPSYDYEMcj4niB5Uk=
Expand All @@ -85,10 +88,13 @@ github.com/aws/aws-sdk-go-v2/service/iam v1.16.0 h1:A4sCxN1jRqmF90FXjYpai1H4z2je
github.com/aws/aws-sdk-go-v2/service/iam v1.16.0/go.mod h1:Nz3L2VG2bK1gJqZejQpBNpMHORGHre5GRAC2v8v8ZDM=
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.7.0 h1:4QAOB3KrvI1ApJK14sliGr3Ie2pjyvNypn/lfzDHfUw=
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.7.0/go.mod h1:K/qPe6AP2TGYv4l6n7c88zh9jWBDf6nHhvg1fx/EWfU=
github.com/aws/aws-sdk-go-v2/service/route53domains v1.8.0 h1:bj6AEE9MkS1iDxTwy7j/nPPg36Na8oxBpQqixdkOlZQ=
github.com/aws/aws-sdk-go-v2/service/route53domains v1.8.0/go.mod h1:QFRIvT3BRBJ3p7GtYtD60dxRaQKWPtlcltL11xPPD1M=
github.com/aws/aws-sdk-go-v2/service/sso v1.9.0 h1:1qLJeQGBmNQW3mBNzK2CFmrQNmoXWrscPqsrAaU1aTA=
github.com/aws/aws-sdk-go-v2/service/sso v1.9.0/go.mod h1:vCV4glupK3tR7pw7ks7Y4jYRL86VvxS+g5qk04YeWrU=
github.com/aws/aws-sdk-go-v2/service/sts v1.14.0 h1:ksiDXhvNYg0D2/UFkLejsaz3LqpW5yjNQ8Nx9Sn2c0E=
github.com/aws/aws-sdk-go-v2/service/sts v1.14.0/go.mod h1:u0xMJKDvvfocRjiozsoZglVNXRG19043xzp3r2ivLIk=
github.com/aws/smithy-go v1.9.0/go.mod h1:SObp3lf9smib00L/v3U2eAKG8FyQ7iLrJnQiAmR5n+E=
github.com/aws/smithy-go v1.10.0 h1:gsoZQMNHnX+PaghNw4ynPsyGP7aUCqx5sY2dlPQsZ0w=
github.com/aws/smithy-go v1.10.0/go.mod h1:SObp3lf9smib00L/v3U2eAKG8FyQ7iLrJnQiAmR5n+E=
github.com/beevik/etree v1.1.0 h1:T0xke/WvNtMoCqgzPhkX2r4rjY3GDZFi+FjpRZY2Jbs=
Expand Down
Loading