Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_appmesh_virtual_node: AWS App Mesh support for TLS in transit encryption #12541

Merged
merged 21 commits into from
Sep 30, 2020
Merged

r/aws_appmesh_virtual_node: AWS App Mesh support for TLS in transit encryption #12541

merged 21 commits into from
Sep 30, 2020

Commits on Sep 30, 2020

  1. r/aws_appmesh_virtual_node: Add listener.tls attribute. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
--- PASS: TestAccAWSAppmesh (221.62s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (221.62s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (114.06s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (40.76s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (41.45s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (25.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	221.667s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    eb0a513 View commit details
    Browse the repository at this point in the history

  2. r/aws_appmesh_virtual_node: Test listener.tls attribute. 

    Disable SDS support (ForbiddenException: TLS Certificates from SDS are not supported).

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/tls'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/tls -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/tls
--- PASS: TestAccAWSAppmesh (56.32s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (56.32s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tls (56.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.365s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e5e653d View commit details
    Browse the repository at this point in the history

  3. r/aws_appmesh_virtual_node: Add backend.virtual_service.client_policy… 

    … attribute.

TODO: Enabled acceptance tests.

Acceptance testing output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/tls
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
--- PASS: TestAccAWSAppmesh (283.47s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (283.47s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tls (56.13s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (26.08s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (115.83s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (43.04s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (42.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	283.517s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    47d441f View commit details
    Browse the repository at this point in the history

  4. r/aws_appmesh_virtual_node: Test backend.virtual_service.client_polic… 

    …y...file attribute.

Acceptance testing output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/clientPolicyFile'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/clientPolicyFile -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/clientPolicyFile
--- PASS: TestAccAWSAppmesh (41.99s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (41.99s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/clientPolicyFile (41.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.027s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f8b7e37 View commit details
    Browse the repository at this point in the history

  5. r/aws_appmesh_virtual_node: Test backend.virtual_service.client_polic… 

    …y...acm attribute.

Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/clientPolicyAcm'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/clientPolicyAcm -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/clientPolicyAcm
--- PASS: TestAccAWSAppmesh (68.09s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (68.09s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/clientPolicyAcm (68.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.124s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    9c8df8b View commit details
    Browse the repository at this point in the history

  6. r/aws_appmesh_virtual_node: Add spec.backend_defaults attribute. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/clientPolicyFile'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/clientPolicyFile -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/clientPolicyFile
--- PASS: TestAccAWSAppmesh (42.17s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (42.17s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/clientPolicyFile (42.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.221s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    bd908b5 View commit details
    Browse the repository at this point in the history

  7. r/aws_appmesh_virtual_node: Test spec.backend_defaults attribute. 

    Acceptance test output:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh/VirtualNode/backendDefaults'
==> Checking that code complies with gofmt requirements...
GO111MODULE=off TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh/VirtualNode/backendDefaults -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/backendDefaults
--- PASS: TestAccAWSAppmesh (41.99s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (41.99s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/backendDefaults (41.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.047s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    58e4381 View commit details
    Browse the repository at this point in the history

  8. Remove artifacts of other preview features.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e7e8365 View commit details
    Browse the repository at this point in the history

  9. Remove commented-out references to 'sds'. That features is not out of… 

    … preview.
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    1d18576 View commit details
    Browse the repository at this point in the history

  10. Use multierror in test sweeper: 

    $ TEST=./aws SWEEP=us-west-2 SWEEPARGS=-sweep-run=aws_appmesh_virtual_node make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./aws -v -sweep=us-west-2 -sweep-run=aws_appmesh_virtual_node -timeout 60m
2020/03/26 12:28:45 [DEBUG] Running Sweepers for region (us-west-2):
2020/03/26 12:28:45 [DEBUG] Running Sweeper (aws_appmesh_virtual_node) in region (us-west-2)
2020/03/26 12:28:45 [INFO] Building AWS auth structure
2020/03/26 12:28:45 [INFO] Setting AWS metadata API timeout to 100ms
2020/03/26 12:28:47 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2020/03/26 12:28:47 [INFO] AWS Auth provider used: "EnvProvider"
2020/03/26 12:28:47 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/03/26 12:28:47 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2020/03/26 12:28:48 Sweeper Tests ran successfully:
	- aws_appmesh_virtual_node
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.607s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    4668de1 View commit details
    Browse the repository at this point in the history

  11. Fix testAccAwsAppmeshVirtualNode_tls acceptance test.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    a357177 View commit details
    Browse the repository at this point in the history

  12. Simplify certificate handling - Some TODOs.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    cfb3d7c View commit details
    Browse the repository at this point in the history

  13. r/aws_acmpca_certificate_authority: Test CA activation. 

    Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAcmpcaCertificateAuthority_Enabled'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsAcmpcaCertificateAuthority_Enabled -timeout 120m
=== RUN   TestAccAwsAcmpcaCertificateAuthority_Enabled
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_Enabled
=== CONT  TestAccAwsAcmpcaCertificateAuthority_Enabled
--- PASS: TestAccAwsAcmpcaCertificateAuthority_Enabled (69.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	69.989s

Add 'TestAccAwsAcmpcaCertificateAuthority_disappears'.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsAcmpcaCertificateAuthority_disappears'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsAcmpcaCertificateAuthority_disappears -timeout 120m
=== RUN   TestAccAwsAcmpcaCertificateAuthority_disappears
=== PAUSE TestAccAwsAcmpcaCertificateAuthority_disappears
=== CONT  TestAccAwsAcmpcaCertificateAuthority_disappears
--- PASS: TestAccAwsAcmpcaCertificateAuthority_disappears (25.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.138s
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b2b05cf View commit details
    Browse the repository at this point in the history

  14. Address TODOs.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    78fac67 View commit details
    Browse the repository at this point in the history

  15. 'flattenIntList' -> 'flattenInt64List' to match corresponding 'expand… 

    …' function.
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    7849c50 View commit details
    Browse the repository at this point in the history

  16. Correct listener index in acceptance tests.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    a5387f7 View commit details
    Browse the repository at this point in the history

  17. Use 'TestCheckTypeSetElemNestedAttrs'.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    2acf980 View commit details
    Browse the repository at this point in the history

  18. r/aws_appmesh_virtual_node: Fix 'testAccAwsAppmeshVirtualNode_clientP… 

    …olicyAcm'.
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f31af93 View commit details
    Browse the repository at this point in the history

  19. r/aws_appmesh_virtual_node: Delete 'appmeshVirtualNodeBackendHash'.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    fb6ad39 View commit details
    Browse the repository at this point in the history

  20. r/aws_appmesh_virtual_node: Tidy up acceptance tests.

    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    9b8caf6 View commit details
    Browse the repository at this point in the history

  21. r/aws_acmpca_certificate_authority: Add 'testAccCheckAwsAcmpcaCertifi… 

    …cateAuthorityDisableCA'.
    @ewbankkit
    ewbankkit committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    1a02e79 View commit details
    Browse the repository at this point in the history