Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation checks for aws_glue_catalog_table resource properties #12523

Merged
merged 1 commit into from
Oct 21, 2020
Merged

add validation checks for aws_glue_catalog_table resource properties #12523

merged 1 commit into from
Oct 21, 2020

Conversation

drexler
Copy link
Contributor

@drexler drexler commented Mar 25, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12519

Release note for CHANGELOG:

add validation checks for aws_glue_catalog_table resource properties

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogTable_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_basic -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_basic
--- PASS: TestAccAWSGlueCatalogTable_basic (24.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.725s

...

@drexler drexler requested a review from a team March 25, 2020 12:55
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 25, 2020
@DrFaust92
Copy link
Collaborator

Hey @drexler, can you rebase this and move validations to be inline using provided validations funcs (i.e validation.IntAtLeast(1))

@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. enhancement Requests to existing resources that expand the functionality or scope. labels Aug 29, 2020
@drexler
Copy link
Contributor Author

drexler commented Aug 31, 2020

Hey @drexler, can you rebase this and move validations to be inline using provided validations funcs (i.e validation.IntAtLeast(1))

@DrFaust92 sure, I'll take care of it.

@DrFaust92
Copy link
Collaborator

Hey @drexler, are you still working on this? if so please rebase otherwise i can fork this branch and make the changes.

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Sep 25, 2020
@drexler
Copy link
Contributor Author

drexler commented Sep 25, 2020

Hey @drexler, are you still working on this? if so please rebase otherwise i can fork this branch and make the changes.

@DrFaust92 i rebased and inlined the validation checks. Sorry for the delay in getting back to this.

DrFaust92
DrFaust92 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSGlueCatalogTable_basic (42.40s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @drexler!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_recreates
=== PAUSE TestAccAWSGlueCatalogTable_recreates
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_recreates
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:375: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:331: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:353: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:375: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:331: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:353: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_disappears
    resource_aws_glue_catalog_table_test.go:396: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_disappears (17.94s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (18.11s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (18.14s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (18.34s)
=== CONT  TestAccAWSGlueCatalogTable_recreates
    resource_aws_glue_catalog_table_test.go:19: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_full (19.79s)
--- PASS: TestAccAWSGlueCatalogTable_basic (19.99s)
=== CONT  TestAccAWSGlueCatalogTable_recreates
    resource_aws_glue_catalog_table_test.go:19: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_recreates (25.04s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (30.94s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (31.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.832s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 120m
=== RUN   TestAccAWSGlueCatalogTable_recreates
=== PAUSE TestAccAWSGlueCatalogTable_recreates
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_recreates
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:331: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:353: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:375: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:331: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_disappears
    resource_aws_glue_catalog_table_test.go:396: [INFO] Got non-empty plan, as expected
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:353: [INFO] Got non-empty plan, as expected
2020/10/21 08:55:22 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
    resource_aws_glue_catalog_table_test.go:375: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (12.61s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (12.73s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (13.02s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (13.87s)
=== CONT  TestAccAWSGlueCatalogTable_recreates
    resource_aws_glue_catalog_table_test.go:19: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_basic (14.92s)
--- PASS: TestAccAWSGlueCatalogTable_full (15.77s)
=== CONT  TestAccAWSGlueCatalogTable_recreates
    resource_aws_glue_catalog_table_test.go:19: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueCatalogTable_recreates (17.93s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (22.35s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (23.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.187s

@breathingdust breathingdust added this to the v3.12.0 milestone Oct 21, 2020
@breathingdust breathingdust merged commit 49cf0c4 into hashicorp:master Oct 21, 2020
breathingdust added a commit that referenced this pull request Oct 21, 2020
@breathingdust
Update CHANGELOG.md for #12523
40d9cb7
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.

aws_glue_catalog_table.ser_de_info.name is documented as optional, but fails if not specified
3 participants
@drexler @DrFaust92 @breathingdust