Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing example resource #12224

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fixing example resource #12224

merged 1 commit into from
Mar 3, 2020

Conversation

gfranchini
Copy link
Contributor

This example returns an error because: A data resource "aws_subnet" "for-each-example" has not been declared in web. Updating the example to use a declared resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@gfranchini
Fixing example resource
8eefb26 
This example returns an error because: `A data resource "aws_subnet" "for-each-example" has not been declared in web.` Updating the example to use a declared resource.
@gfranchini gfranchini requested a review from a team March 2, 2020 19:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. labels Mar 2, 2020
bflad
bflad approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, @gfranchini 🚀

@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2020
@bflad bflad added this to the v2.52.0 milestone Mar 3, 2020
@bflad bflad merged commit 3c2fe1b into hashicorp:master Mar 3, 2020
bflad added a commit that referenced this pull request Mar 4, 2020
@bflad
provider: Additional hashibot pull request labeling
a49012a 
Reference: #11567 (missing aws_cur_report service label)
Reference: #12103 (missing aws_snapshot_create_volume_permission service label)
Reference: #12020 / #12224 (missing aws_subnet_ids service label)
@bflad bflad mentioned this pull request Mar 4, 2020
Merged
@ghost
Copy link

ghost commented Mar 6, 2020

This has been released in version 2.52.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@gfranchini gfranchini deleted the patch-1 branch March 9, 2020 20:47
bflad added a commit that referenced this pull request Mar 10, 2020
@bflad
provider: Additional hashibot pull request labeling (#12241)
4f26bb3 
Reference: #11567 (missing aws_cur_report service label)
Reference: #12103 (missing aws_snapshot_create_volume_permission service label)
Reference: #12020 / #12224 (missing aws_subnet_ids service label)
@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gfranchini @bflad