Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update count example syntax to 0.12 #11557

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Update count example syntax to 0.12 #11557

merged 1 commit into from
Jul 13, 2020

Conversation

danieldreier
Copy link
Contributor

@caseylang mentioned to me that the count examples were out of date with 0.12 syntax. This is the result of running the 0.12upgrade tool on the count examples

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Update count example syntax to 0.12
1568e9d 
This is the result of running the 0.12upgrade tool on the count examples
@danieldreier danieldreier requested a review from a team January 11, 2020 00:14
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jan 11, 2020
@anGie44 anGie44 added terraform-0.12 and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 3, 2020
@anGie44
Copy link
Contributor

anGie44 commented Jun 3, 2020

hi @danieldreier, thank you for this PR! please note the Terraform AWS provider will deprecate support for TF 0.11 in 3.0.0 which can be tracked here: #8950. We're holding off merging PRs that convert syntax across the documentation nevertheless this PR has been marked as part of the 3.0.0 milestone and will be evaluated when work towards that release begins.

@anGie44 anGie44 added this to the v3.0.0 milestone Jun 3, 2020
bflad
bflad approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @danieldreier! 🚀

@bflad bflad merged commit a6d6943 into hashicorp:master Jul 13, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caseylang caseylang caseylang approved these changes

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danieldreier @anGie44 @bflad @caseylang