Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resource_aws_sns_topic_subscription to create the subscription… #10496

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Update resource_aws_sns_topic_subscription to create the subscription… #10496

merged 2 commits into from
Oct 2, 2020

Commits on Oct 13, 2019

  1. Update resource_aws_sns_topic_subscription to create the subscription… 

    … attributes simulatenously with the general subscription creation

Previously the attributes were created _after_ the subscription was created. This left a few seconds in time where messages from the topic could make it through to the endpoint without adhering to things like the FilterPolicy and the RawMessageDelivery flag.
    Carlos-Zaragoza authored and Carlos-Zaragoza committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    a14f2e1 View commit details
    Browse the repository at this point in the history

  2. Simplify conditional

    Carlos-Zaragoza authored and Carlos-Zaragoza committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    5823502 View commit details
    Browse the repository at this point in the history